[GitHub] [spark] brkyvz commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2

2019-07-16 Thread GitBox
brkyvz commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#issuecomment-511996105 Approach and interface LGTM! +9000 on "keep[ing] commits smaller and more focused." in the future. Would r

[GitHub] [spark] brkyvz commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2

2019-07-16 Thread GitBox
brkyvz commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#issuecomment-511937029 I don't like large PRs either, but I also think that you can't build good abstractions before you have v