[GitHub] [spark] chenzhx commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

2022-07-05 Thread GitBox
chenzhx commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r913449545 ## sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala: ## @@ -1026,18 +1034,93 @@ class JDBCV2Suite extends QueryTest with SharedSparkSession with Expl

[GitHub] [spark] chenzhx commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

2022-07-04 Thread GitBox
chenzhx commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r913413624 ## sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala: ## @@ -1026,18 +1034,97 @@ class JDBCV2Suite extends QueryTest with SharedSparkSession with Expl

[GitHub] [spark] chenzhx commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

2022-07-04 Thread GitBox
chenzhx commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r913409855 ## sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala: ## @@ -1026,14 +1035,86 @@ class JDBCV2Suite extends QueryTest with SharedSparkSession with Expl

[GitHub] [spark] chenzhx commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

2022-06-30 Thread GitBox
chenzhx commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r910881528 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java: ## @@ -290,4 +297,15 @@ protected String visitTrim(String direction, Strin

[GitHub] [spark] chenzhx commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

2022-06-30 Thread GitBox
chenzhx commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r910881528 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java: ## @@ -290,4 +297,15 @@ protected String visitTrim(String direction, Strin

[GitHub] [spark] chenzhx commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

2022-06-30 Thread GitBox
chenzhx commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r910737639 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala: ## @@ -123,4 +127,26 @@ private[sql] object H2Dialect extends JdbcDialect { } super.class

[GitHub] [spark] chenzhx commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

2022-06-30 Thread GitBox
chenzhx commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r910737639 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala: ## @@ -123,4 +127,26 @@ private[sql] object H2Dialect extends JdbcDialect { } super.class

[GitHub] [spark] chenzhx commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

2022-06-30 Thread GitBox
chenzhx commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r910737639 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala: ## @@ -123,4 +127,26 @@ private[sql] object H2Dialect extends JdbcDialect { } super.class

[GitHub] [spark] chenzhx commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

2022-06-30 Thread GitBox
chenzhx commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r910737639 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala: ## @@ -123,4 +127,26 @@ private[sql] object H2Dialect extends JdbcDialect { } super.class

[GitHub] [spark] chenzhx commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

2022-06-28 Thread GitBox
chenzhx commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r907174118 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -254,6 +254,55 @@ class V2ExpressionBuilder(e: Expression, isPredicate: B

[GitHub] [spark] chenzhx commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

2022-06-27 Thread GitBox
chenzhx commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r908011517 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -254,6 +254,55 @@ class V2ExpressionBuilder(e: Expression, isPredicate: B

[GitHub] [spark] chenzhx commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

2022-06-27 Thread GitBox
chenzhx commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r907173999 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -254,6 +254,55 @@ class V2ExpressionBuilder(e: Expression, isPredicate: B

[GitHub] [spark] chenzhx commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

2022-06-27 Thread GitBox
chenzhx commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r907162042 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Extract.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [spark] chenzhx commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

2022-06-27 Thread GitBox
chenzhx commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r907122926 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -254,6 +254,55 @@ class V2ExpressionBuilder(e: Expression, isPredicate: B

[GitHub] [spark] chenzhx commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

2022-06-22 Thread GitBox
chenzhx commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r903468324 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -262,6 +262,55 @@ class V2ExpressionBuilder( } else { None

[GitHub] [spark] chenzhx commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

2022-06-09 Thread GitBox
chenzhx commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r893244434 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/GeneralScalarExpression.java: ## @@ -196,6 +196,90 @@ *Since version: 3.4.0 * * +

[GitHub] [spark] chenzhx commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

2022-06-09 Thread GitBox
chenzhx commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r893144700 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -259,6 +259,55 @@ class V2ExpressionBuilder( } else { None

[GitHub] [spark] chenzhx commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

2022-06-09 Thread GitBox
chenzhx commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r893141595 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/GeneralScalarExpression.java: ## @@ -196,6 +196,90 @@ *Since version: 3.4.0 * * +

[GitHub] [spark] chenzhx commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

2022-06-07 Thread GitBox
chenzhx commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r890253947 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -259,6 +259,55 @@ class V2ExpressionBuilder( } else { None

[GitHub] [spark] chenzhx commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

2022-06-06 Thread GitBox
chenzhx commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r890253947 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -259,6 +259,55 @@ class V2ExpressionBuilder( } else { None

[GitHub] [spark] chenzhx commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

2022-05-27 Thread GitBox
chenzhx commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r883473729 ## sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala: ## @@ -539,6 +547,44 @@ class JDBCV2Suite extends QueryTest with SharedSparkSession with Explain

[GitHub] [spark] chenzhx commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

2022-05-27 Thread GitBox
chenzhx commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r883471600 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/GeneralScalarExpression.java: ## @@ -196,6 +196,96 @@ *Since version: 3.4.0 * * +

[GitHub] [spark] chenzhx commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

2022-05-25 Thread GitBox
chenzhx commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r881484738 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/GeneralScalarExpression.java: ## @@ -196,6 +196,84 @@ *Since version: 3.4.0 * * +