[GitHub] [spark] cloud-fan commented on a change in pull request #29328: [SPARK-32516][SQL] 'path' option cannot co-exist with load()'s path parameters

2020-08-10 Thread GitBox
cloud-fan commented on a change in pull request #29328: URL: https://github.com/apache/spark/pull/29328#discussion_r468326123 ## File path: sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala ## @@ -395,7 +395,7 @@ class DataFrameReaderWriterSuit

[GitHub] [spark] cloud-fan commented on a change in pull request #29328: [SPARK-32516][SQL] 'path' option cannot co-exist with load()'s path parameters

2020-08-10 Thread GitBox
cloud-fan commented on a change in pull request #29328: URL: https://github.com/apache/spark/pull/29328#discussion_r468326123 ## File path: sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala ## @@ -395,7 +395,7 @@ class DataFrameReaderWriterSuit

[GitHub] [spark] cloud-fan commented on a change in pull request #29328: [SPARK-32516][SQL] 'path' option cannot co-exist with load()'s path parameters

2020-08-10 Thread GitBox
cloud-fan commented on a change in pull request #29328: URL: https://github.com/apache/spark/pull/29328#discussion_r468324590 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVDataSource.scala ## @@ -155,7 +155,7 @@ object TextInputCSVData

[GitHub] [spark] cloud-fan commented on a change in pull request #29328: [SPARK-32516][SQL] 'path' option cannot co-exist with load()'s path parameters

2020-08-10 Thread GitBox
cloud-fan commented on a change in pull request #29328: URL: https://github.com/apache/spark/pull/29328#discussion_r468324072 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -245,12 +245,19 @@ class DataFrameReader private[sql](sparkSessio

[GitHub] [spark] cloud-fan commented on a change in pull request #29328: [SPARK-32516][SQL] 'path' option cannot co-exist with load()'s path parameters

2020-08-10 Thread GitBox
cloud-fan commented on a change in pull request #29328: URL: https://github.com/apache/spark/pull/29328#discussion_r468323610 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -245,12 +245,19 @@ class DataFrameReader private[sql](sparkSessio

[GitHub] [spark] cloud-fan commented on a change in pull request #29328: [SPARK-32516][SQL] 'path' option cannot co-exist with load()'s path parameters

2020-08-10 Thread GitBox
cloud-fan commented on a change in pull request #29328: URL: https://github.com/apache/spark/pull/29328#discussion_r468323149 ## File path: docs/sql-migration-guide.md ## @@ -36,6 +36,8 @@ license: | - In Spark 3.1, NULL elements of structures, arrays and maps are converte

[GitHub] [spark] cloud-fan commented on a change in pull request #29328: [SPARK-32516][SQL] 'path' option cannot co-exist with load()'s path parameters

2020-08-10 Thread GitBox
cloud-fan commented on a change in pull request #29328: URL: https://github.com/apache/spark/pull/29328#discussion_r468322696 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -245,6 +246,10 @@ class DataFrameReader private[sql](sparkSession

[GitHub] [spark] cloud-fan commented on a change in pull request #29328: [SPARK-32516][SQL] 'path' option cannot co-exist with load()'s path parameters

2020-08-10 Thread GitBox
cloud-fan commented on a change in pull request #29328: URL: https://github.com/apache/spark/pull/29328#discussion_r468305334 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -245,6 +246,10 @@ class DataFrameReader private[sql](sparkSession

[GitHub] [spark] cloud-fan commented on a change in pull request #29328: [SPARK-32516][SQL] 'path' option cannot co-exist with load()'s path parameters

2020-08-09 Thread GitBox
cloud-fan commented on a change in pull request #29328: URL: https://github.com/apache/spark/pull/29328#discussion_r467684583 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -245,6 +246,10 @@ class DataFrameReader private[sql](sparkSession

[GitHub] [spark] cloud-fan commented on a change in pull request #29328: [SPARK-32516][SQL] 'path' option cannot co-exist with load()'s path parameters

2020-08-06 Thread GitBox
cloud-fan commented on a change in pull request #29328: URL: https://github.com/apache/spark/pull/29328#discussion_r466836253 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -229,6 +229,7 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] [spark] cloud-fan commented on a change in pull request #29328: [SPARK-32516][SQL] 'path' option cannot co-exist with load()'s path parameters

2020-08-06 Thread GitBox
cloud-fan commented on a change in pull request #29328: URL: https://github.com/apache/spark/pull/29328#discussion_r466829121 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -229,7 +229,7 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] [spark] cloud-fan commented on a change in pull request #29328: [SPARK-32516][SQL] 'path' option cannot co-exist with load()'s path parameters

2020-08-06 Thread GitBox
cloud-fan commented on a change in pull request #29328: URL: https://github.com/apache/spark/pull/29328#discussion_r466829121 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -229,7 +229,7 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] [spark] cloud-fan commented on a change in pull request #29328: [SPARK-32516][SQL] 'path' option cannot co-exist with load()'s path parameters

2020-08-06 Thread GitBox
cloud-fan commented on a change in pull request #29328: URL: https://github.com/apache/spark/pull/29328#discussion_r466818655 ## File path: sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala ## @@ -224,15 +224,15 @@ class DataFrameReaderWriterSu

[GitHub] [spark] cloud-fan commented on a change in pull request #29328: [SPARK-32516][SQL] 'path' option cannot co-exist with load()'s path parameters

2020-08-06 Thread GitBox
cloud-fan commented on a change in pull request #29328: URL: https://github.com/apache/spark/pull/29328#discussion_r466818465 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -229,7 +229,7 @@ class DataFrameReader private[sql](sparkSession: