[GitHub] [spark] cloud-fan commented on a change in pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

cloud-fan commented on a change in pull request #29893: URL: https://github.com/apache/spark/pull/29893#discussion_r545308284 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSQLInsertTestSuite.scala ## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [spark] cloud-fan commented on a change in pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

cloud-fan commented on a change in pull request #29893: URL: https://github.com/apache/spark/pull/29893#discussion_r531487820 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLInsertTestSuite.scala ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [spark] cloud-fan commented on a change in pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

cloud-fan commented on a change in pull request #29893: URL: https://github.com/apache/spark/pull/29893#discussion_r531487331 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLInsertTestSuite.scala ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [spark] cloud-fan commented on a change in pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

cloud-fan commented on a change in pull request #29893: URL: https://github.com/apache/spark/pull/29893#discussion_r531486612 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -3104,6 +3106,48 @@ class Analyzer(override val c

[GitHub] [spark] cloud-fan commented on a change in pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

cloud-fan commented on a change in pull request #29893: URL: https://github.com/apache/spark/pull/29893#discussion_r531448088 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLInsertTestSuite.scala ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [spark] cloud-fan commented on a change in pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

cloud-fan commented on a change in pull request #29893: URL: https://github.com/apache/spark/pull/29893#discussion_r531447037 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLInsertTestSuite.scala ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [spark] cloud-fan commented on a change in pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

cloud-fan commented on a change in pull request #29893: URL: https://github.com/apache/spark/pull/29893#discussion_r531446155 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLInsertTestSuite.scala ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [spark] cloud-fan commented on a change in pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

cloud-fan commented on a change in pull request #29893: URL: https://github.com/apache/spark/pull/29893#discussion_r531445867 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLInsertTestSuite.scala ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [spark] cloud-fan commented on a change in pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

cloud-fan commented on a change in pull request #29893: URL: https://github.com/apache/spark/pull/29893#discussion_r531422458 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLInsertTestSuite.scala ## @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [spark] cloud-fan commented on a change in pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

cloud-fan commented on a change in pull request #29893: URL: https://github.com/apache/spark/pull/29893#discussion_r531421673 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLInsertTestSuite.scala ## @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [spark] cloud-fan commented on a change in pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

cloud-fan commented on a change in pull request #29893: URL: https://github.com/apache/spark/pull/29893#discussion_r531421389 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLInsertTestSuite.scala ## @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [spark] cloud-fan commented on a change in pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

cloud-fan commented on a change in pull request #29893: URL: https://github.com/apache/spark/pull/29893#discussion_r531420156 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLInsertTestSuite.scala ## @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [spark] cloud-fan commented on a change in pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

cloud-fan commented on a change in pull request #29893: URL: https://github.com/apache/spark/pull/29893#discussion_r531419671 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLInsertTestSuite.scala ## @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [spark] cloud-fan commented on a change in pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

cloud-fan commented on a change in pull request #29893: URL: https://github.com/apache/spark/pull/29893#discussion_r531419418 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLInsertTestSuite.scala ## @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [spark] cloud-fan commented on a change in pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

cloud-fan commented on a change in pull request #29893: URL: https://github.com/apache/spark/pull/29893#discussion_r531418779 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ## @@ -522,7 +523,8 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] [spark] cloud-fan commented on a change in pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

cloud-fan commented on a change in pull request #29893: URL: https://github.com/apache/spark/pull/29893#discussion_r531418233 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -3104,6 +3106,62 @@ class Analyzer(override val c

[GitHub] [spark] cloud-fan commented on a change in pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

cloud-fan commented on a change in pull request #29893: URL: https://github.com/apache/spark/pull/29893#discussion_r530475127 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -3104,6 +3106,66 @@ class Analyzer(override val c

[GitHub] [spark] cloud-fan commented on a change in pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

cloud-fan commented on a change in pull request #29893: URL: https://github.com/apache/spark/pull/29893#discussion_r530471201 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -3718,6 +3718,49 @@ class SQLQuerySuite extends QueryTest with Sha

[GitHub] [spark] cloud-fan commented on a change in pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

cloud-fan commented on a change in pull request #29893: URL: https://github.com/apache/spark/pull/29893#discussion_r530471201 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -3718,6 +3718,49 @@ class SQLQuerySuite extends QueryTest with Sha

[GitHub] [spark] cloud-fan commented on a change in pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

cloud-fan commented on a change in pull request #29893: URL: https://github.com/apache/spark/pull/29893#discussion_r530465028 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statements.scala ## @@ -290,6 +291,7 @@ case class DropViewStatem

[GitHub] [spark] cloud-fan commented on a change in pull request #29893: [SPARK-32976][SQL]Support column list in INSERT statement

cloud-fan commented on a change in pull request #29893: URL: https://github.com/apache/spark/pull/29893#discussion_r530459131 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -299,13 +301,16 @@ class AstBuilder extends SqlBa