[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-05-25 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r638909542 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -17,71 +17,155 @@ package org.apa

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-05-25 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r638911201 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -17,71 +17,155 @@ package org.apa

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-05-25 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r638911496 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -17,71 +17,155 @@ package org.apa

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-05-25 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r638918033 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -17,71 +17,155 @@ package org.apa

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-05-25 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r638921071 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -149,67 +234,52 @@ object NestedColu

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-05-25 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r638924260 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -149,67 +234,52 @@ object NestedColu

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-05-25 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r638933402 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -17,71 +17,155 @@ package org.apa

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-05-25 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r638934740 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -149,67 +234,52 @@ object NestedColu

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-05-25 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r638939038 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -227,137 +297,114 @@ object NestedCo

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-05-25 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r638943696 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -227,137 +297,114 @@ object NestedCo

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-05-25 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r638945342 ## File path: sql/catalyst/src/main/scala-2.12/org/apache/spark/sql/catalyst/expressions/AttributeMap.scala ## @@ -37,6 +37,8 @@ class AttributeMap[A](

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-05-25 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r639414608 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -17,71 +17,155 @@ package org.apa

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-05-25 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r639418807 ## File path: sql/catalyst/src/main/scala-2.12/org/apache/spark/sql/catalyst/expressions/AttributeMap.scala ## @@ -23,6 +23,10 @@ package org.apache.sp

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-05-26 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r639948954 ## File path: sql/catalyst/src/main/scala-2.12/org/apache/spark/sql/catalyst/expressions/AttributeMap.scala ## @@ -23,6 +23,10 @@ package org.apache.sp

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-05-27 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r640353935 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -17,71 +17,155 @@ package org.apa

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-04-23 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r619296928 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -30,54 +30,61 @@ import org.apache.s

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-04-26 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r620104642 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -23,78 +23,149 @@ import org.apache.

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-04-26 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r620111033 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -23,78 +23,149 @@ import org.apache.

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-04-26 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r620111958 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -783,7 +783,7 @@ object ColumnPruning extends R

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-04-26 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r620117769 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -133,83 +204,77 @@ object NestedColu

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-04-26 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r620122510 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -133,83 +204,77 @@ object NestedColu

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-04-26 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r620133124 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -133,83 +204,77 @@ object NestedColu

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-04-26 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r620136649 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -133,83 +204,77 @@ object NestedColu

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-04-26 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r620137246 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -133,83 +204,77 @@ object NestedColu

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-04-26 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r620138804 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -23,78 +23,149 @@ import org.apache.

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-04-26 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r620139197 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -23,78 +23,149 @@ import org.apache.

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-04-28 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r621969848 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -23,78 +23,149 @@ import org.apache.

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-04-28 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r622727661 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -133,83 +204,77 @@ object NestedColu

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-04-28 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r622728340 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -17,71 +17,148 @@ package org.apa

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-04-28 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r622728488 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -17,71 +17,148 @@ package org.apa

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-04-28 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r622728793 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -17,71 +17,148 @@ package org.apa

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-04-28 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r622729279 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -17,71 +17,148 @@ package org.apa

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-04-28 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r622729699 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -133,83 +204,77 @@ object NestedColu

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-04-28 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r622728793 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -17,71 +17,148 @@ package org.apa

[GitHub] [spark] cloud-fan commented on a change in pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-04-28 Thread GitBox
cloud-fan commented on a change in pull request #32301: URL: https://github.com/apache/spark/pull/32301#discussion_r622729279 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -17,71 +17,148 @@ package org.apa