[GitHub] [spark] cloud-fan commented on a change in pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

2021-08-23 Thread GitBox
cloud-fan commented on a change in pull request #33736: URL: https://github.com/apache/spark/pull/33736#discussion_r694054229 ## File path: sql/core/src/test/scala/org/apache/spark/sql/TPCBase.scala ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [spark] cloud-fan commented on a change in pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

2021-08-18 Thread GitBox
cloud-fan commented on a change in pull request #33736: URL: https://github.com/apache/spark/pull/33736#discussion_r691305225 ## File path: sql/core/src/test/scala/org/apache/spark/sql/PlanSuiteBase.scala ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [spark] cloud-fan commented on a change in pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

2021-08-18 Thread GitBox
cloud-fan commented on a change in pull request #33736: URL: https://github.com/apache/spark/pull/33736#discussion_r691307948 ## File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala ## @@ -102,15 +88,9 @@ trait TPCDSBase extends SharedSparkSession with

[GitHub] [spark] cloud-fan commented on a change in pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

2021-08-18 Thread GitBox
cloud-fan commented on a change in pull request #33736: URL: https://github.com/apache/spark/pull/33736#discussion_r691305225 ## File path: sql/core/src/test/scala/org/apache/spark/sql/PlanSuiteBase.scala ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [spark] cloud-fan commented on a change in pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

2021-08-17 Thread GitBox
cloud-fan commented on a change in pull request #33736: URL: https://github.com/apache/spark/pull/33736#discussion_r690234889 ## File path: sql/core/src/test/scala/org/apache/spark/sql/PlanStabilitySuite.scala ## @@ -66,7 +66,7 @@ import org.apache.spark.sql.internal.SQLConf

[GitHub] [spark] cloud-fan commented on a change in pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

2021-08-16 Thread GitBox
cloud-fan commented on a change in pull request #33736: URL: https://github.com/apache/spark/pull/33736#discussion_r690046057 ## File path: sql/core/src/test/scala/org/apache/spark/sql/PlanStabilitySuite.scala ## @@ -333,3 +340,22 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #33736: [SPARK-35991][SQL] Add PlanStability suite for TPCH

2021-08-16 Thread GitBox
cloud-fan commented on a change in pull request #33736: URL: https://github.com/apache/spark/pull/33736#discussion_r690045699 ## File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala ## @@ -79,6 +79,17 @@ trait TPCDSBase extends SharedSparkSession with