[GitHub] [spark] cloud-fan commented on a diff in pull request #36150: [SPARK-38864][SQL] Add melt / unpivot to Dataset

cloud-fan commented on code in PR #36150: URL: https://github.com/apache/spark/pull/36150#discussion_r919724192 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala: ## @@ -863,6 +868,36 @@ class Analyzer(override val catalogManager:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36150: [SPARK-38864][SQL] Add melt / unpivot to Dataset

cloud-fan commented on code in PR #36150: URL: https://github.com/apache/spark/pull/36150#discussion_r919722209 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala: ## @@ -736,6 +736,21 @@ abstract class TypeCoercionBase { } } +

[GitHub] [spark] cloud-fan commented on a diff in pull request #36150: [SPARK-38864][SQL] Add melt / unpivot to Dataset

cloud-fan commented on code in PR #36150: URL: https://github.com/apache/spark/pull/36150#discussion_r919718238 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala: ## @@ -422,6 +426,15 @@ trait CheckAnalysis extends PredicateHelper with

[GitHub] [spark] cloud-fan commented on a diff in pull request #36150: [SPARK-38864][SQL] Add melt / unpivot to Dataset

cloud-fan commented on code in PR #36150: URL: https://github.com/apache/spark/pull/36150#discussion_r919717122 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala: ## @@ -55,6 +55,10 @@ trait CheckAnalysis extends PredicateHelper with

[GitHub] [spark] cloud-fan commented on a diff in pull request #36150: [SPARK-38864][SQL] Add melt / unpivot to Dataset

cloud-fan commented on code in PR #36150: URL: https://github.com/apache/spark/pull/36150#discussion_r919716656 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala: ## @@ -1382,6 +1417,12 @@ class Analyzer(override val catalogManager:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36150: [SPARK-38864][SQL] Add melt / unpivot to Dataset

cloud-fan commented on code in PR #36150: URL: https://github.com/apache/spark/pull/36150#discussion_r919715595 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala: ## @@ -863,6 +868,36 @@ class Analyzer(override val catalogManager:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36150: [SPARK-38864][SQL] Add melt / unpivot to Dataset

cloud-fan commented on code in PR #36150: URL: https://github.com/apache/spark/pull/36150#discussion_r919685963 ## core/src/main/resources/error/error-classes.json: ## @@ -256,6 +256,18 @@ "Key does not exist. Use `try_element_at` to tolerate non-existent key and

[GitHub] [spark] cloud-fan commented on a diff in pull request #36150: [SPARK-38864][SQL] Add melt / unpivot to Dataset

cloud-fan commented on code in PR #36150: URL: https://github.com/apache/spark/pull/36150#discussion_r919012662 ## core/src/main/resources/error/error-classes.json: ## @@ -256,6 +256,18 @@ "Key does not exist. Use `try_element_at` to tolerate non-existent key and

[GitHub] [spark] cloud-fan commented on a diff in pull request #36150: [SPARK-38864][SQL] Add melt / unpivot to Dataset

cloud-fan commented on code in PR #36150: URL: https://github.com/apache/spark/pull/36150#discussion_r919005101 ## core/src/main/resources/error/error-classes.json: ## @@ -256,6 +256,18 @@ "Key does not exist. Use `try_element_at` to tolerate non-existent key and

[GitHub] [spark] cloud-fan commented on a diff in pull request #36150: [SPARK-38864][SQL] Add melt / unpivot to Dataset

cloud-fan commented on code in PR #36150: URL: https://github.com/apache/spark/pull/36150#discussion_r919137239 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala: ## @@ -524,6 +525,10 @@ class Analyzer(override val catalogManager:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36150: [SPARK-38864][SQL] Add melt / unpivot to Dataset

cloud-fan commented on code in PR #36150: URL: https://github.com/apache/spark/pull/36150#discussion_r892631764 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala: ## @@ -1227,6 +1227,49 @@ case class Pivot( override

[GitHub] [spark] cloud-fan commented on a diff in pull request #36150: [SPARK-38864][SQL] Add melt / unpivot to Dataset

cloud-fan commented on code in PR #36150: URL: https://github.com/apache/spark/pull/36150#discussion_r892459971 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala: ## @@ -736,6 +737,24 @@ abstract class TypeCoercionBase { } } +

[GitHub] [spark] cloud-fan commented on a diff in pull request #36150: [SPARK-38864][SQL] Add melt / unpivot to Dataset

cloud-fan commented on code in PR #36150: URL: https://github.com/apache/spark/pull/36150#discussion_r892455937 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala: ## @@ -1227,6 +1227,49 @@ case class Pivot( override

[GitHub] [spark] cloud-fan commented on a diff in pull request #36150: [SPARK-38864][SQL] Add melt / unpivot to Dataset

cloud-fan commented on code in PR #36150: URL: https://github.com/apache/spark/pull/36150#discussion_r891409655 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala: ## @@ -736,6 +737,24 @@ abstract class TypeCoercionBase { } } +

[GitHub] [spark] cloud-fan commented on a diff in pull request #36150: [SPARK-38864][SQL] Add melt / unpivot to Dataset

cloud-fan commented on code in PR #36150: URL: https://github.com/apache/spark/pull/36150#discussion_r891408643 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala: ## @@ -736,6 +737,24 @@ abstract class TypeCoercionBase { } } +

[GitHub] [spark] cloud-fan commented on a diff in pull request #36150: [SPARK-38864][SQL] Add melt / unpivot to Dataset

cloud-fan commented on code in PR #36150: URL: https://github.com/apache/spark/pull/36150#discussion_r891400243 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala: ## @@ -806,6 +825,7 @@ abstract class TypeCoercionBase { object

[GitHub] [spark] cloud-fan commented on a diff in pull request #36150: [SPARK-38864][SQL] Add melt / unpivot to Dataset

cloud-fan commented on code in PR #36150: URL: https://github.com/apache/spark/pull/36150#discussion_r891400243 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala: ## @@ -806,6 +825,7 @@ abstract class TypeCoercionBase { object

[GitHub] [spark] cloud-fan commented on a diff in pull request #36150: [SPARK-38864][SQL] Add melt / unpivot to Dataset

cloud-fan commented on code in PR #36150: URL: https://github.com/apache/spark/pull/36150#discussion_r891397088 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala: ## @@ -1227,6 +1227,49 @@ case class Pivot( override

[GitHub] [spark] cloud-fan commented on a diff in pull request #36150: [SPARK-38864][SQL] Add melt / unpivot to Dataset

cloud-fan commented on code in PR #36150: URL: https://github.com/apache/spark/pull/36150#discussion_r891394188 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala: ## @@ -1227,6 +1227,49 @@ case class Pivot( override

[GitHub] [spark] cloud-fan commented on a diff in pull request #36150: [SPARK-38864][SQL] Add melt / unpivot to Dataset

cloud-fan commented on code in PR #36150: URL: https://github.com/apache/spark/pull/36150#discussion_r885178644 ## sql/core/src/main/scala/org/apache/spark/sql/Melt.scala: ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [spark] cloud-fan commented on a diff in pull request #36150: [SPARK-38864][SQL] Add melt / unpivot to Dataset

cloud-fan commented on code in PR #36150: URL: https://github.com/apache/spark/pull/36150#discussion_r885178329 ## sql/core/src/main/scala/org/apache/spark/sql/Melt.scala: ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [spark] cloud-fan commented on a diff in pull request #36150: [SPARK-38864][SQL] Add melt / unpivot to Dataset

cloud-fan commented on code in PR #36150: URL: https://github.com/apache/spark/pull/36150#discussion_r885177916 ## sql/core/src/main/scala/org/apache/spark/sql/Melt.scala: ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [spark] cloud-fan commented on a diff in pull request #36150: [SPARK-38864][SQL] Add melt / unpivot to Dataset

cloud-fan commented on code in PR #36150: URL: https://github.com/apache/spark/pull/36150#discussion_r885175634 ## sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala: ## @@ -2012,6 +2012,152 @@ class Dataset[T] private[sql]( @scala.annotation.varargs def agg(expr: