[GitHub] [spark] cloud-fan commented on a diff in pull request #36564: [SPARK-39195][SQL] Spark OutputCommitCoordinator should abort stage when committed file not consistent with task status

2022-06-16 Thread GitBox
cloud-fan commented on code in PR #36564: URL: https://github.com/apache/spark/pull/36564#discussion_r899208451 ## core/src/test/scala/org/apache/spark/scheduler/OutputCommitCoordinatorSuite.scala: ## @@ -235,7 +226,6 @@ class OutputCommitCoordinatorSuite extends SparkFunSuite

[GitHub] [spark] cloud-fan commented on a diff in pull request #36564: [SPARK-39195][SQL] Spark OutputCommitCoordinator should abort stage when committed file not consistent with task status

2022-06-15 Thread GitBox
cloud-fan commented on code in PR #36564: URL: https://github.com/apache/spark/pull/36564#discussion_r897951308 ## core/src/test/scala/org/apache/spark/scheduler/OutputCommitCoordinatorSuite.scala: ## @@ -143,13 +144,6 @@ class OutputCommitCoordinatorSuite extends SparkFunSuite

[GitHub] [spark] cloud-fan commented on a diff in pull request #36564: [SPARK-39195][SQL] Spark OutputCommitCoordinator should abort stage when committed file not consistent with task status

2022-06-14 Thread GitBox
cloud-fan commented on code in PR #36564: URL: https://github.com/apache/spark/pull/36564#discussion_r897011726 ## core/src/test/scala/org/apache/spark/scheduler/OutputCommitCoordinatorIntegrationSuite.scala: ## @@ -47,11 +46,12 @@ class OutputCommitCoordinatorIntegrationSuite

[GitHub] [spark] cloud-fan commented on a diff in pull request #36564: [SPARK-39195][SQL] Spark OutputCommitCoordinator should abort stage when committed file not consistent with task status

2022-06-13 Thread GitBox
cloud-fan commented on code in PR #36564: URL: https://github.com/apache/spark/pull/36564#discussion_r895826751 ## core/src/test/scala/org/apache/spark/scheduler/OutputCommitCoordinatorSuite.scala: ## @@ -270,6 +263,16 @@ class OutputCommitCoordinatorSuite extends SparkFunSuite

[GitHub] [spark] cloud-fan commented on a diff in pull request #36564: [SPARK-39195][SQL] Spark OutputCommitCoordinator should abort stage when committed file not consistent with task status

2022-06-10 Thread GitBox
cloud-fan commented on code in PR #36564: URL: https://github.com/apache/spark/pull/36564#discussion_r894636200 ## core/src/test/scala/org/apache/spark/scheduler/OutputCommitCoordinatorSuite.scala: ## @@ -289,6 +289,7 @@ private case class OutputCommitFunctions(tempDirPath:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36564: [SPARK-39195][SQL] Spark OutputCommitCoordinator should abort stage when committed file not consistent with task status

2022-06-10 Thread GitBox
cloud-fan commented on code in PR #36564: URL: https://github.com/apache/spark/pull/36564#discussion_r894635076 ## core/src/test/scala/org/apache/spark/scheduler/OutputCommitCoordinatorSuite.scala: ## @@ -235,7 +226,6 @@ class OutputCommitCoordinatorSuite extends SparkFunSuite

[GitHub] [spark] cloud-fan commented on a diff in pull request #36564: [SPARK-39195][SQL] Spark OutputCommitCoordinator should abort stage when committed file not consistent with task status

2022-06-10 Thread GitBox
cloud-fan commented on code in PR #36564: URL: https://github.com/apache/spark/pull/36564#discussion_r893061431 ## core/src/test/scala/org/apache/spark/scheduler/OutputCommitCoordinatorSuite.scala: ## @@ -187,12 +181,6 @@ class OutputCommitCoordinatorSuite extends SparkFunSuite

[GitHub] [spark] cloud-fan commented on a diff in pull request #36564: [SPARK-39195][SQL] Spark OutputCommitCoordinator should abort stage when committed file not consistent with task status

2022-06-10 Thread GitBox
cloud-fan commented on code in PR #36564: URL: https://github.com/apache/spark/pull/36564#discussion_r894633551 ## core/src/test/scala/org/apache/spark/scheduler/OutputCommitCoordinatorIntegrationSuite.scala: ## @@ -46,21 +45,21 @@ class OutputCommitCoordinatorIntegrationSuite

[GitHub] [spark] cloud-fan commented on a diff in pull request #36564: [SPARK-39195][SQL] Spark OutputCommitCoordinator should abort stage when committed file not consistent with task status

2022-06-10 Thread GitBox
cloud-fan commented on code in PR #36564: URL: https://github.com/apache/spark/pull/36564#discussion_r894632434 ## core/src/test/scala/org/apache/spark/scheduler/OutputCommitCoordinatorIntegrationSuite.scala: ## @@ -46,21 +45,21 @@ class OutputCommitCoordinatorIntegrationSuite

[GitHub] [spark] cloud-fan commented on a diff in pull request #36564: [SPARK-39195][SQL] Spark OutputCommitCoordinator should abort stage when committed file not consistent with task status

2022-06-08 Thread GitBox
cloud-fan commented on code in PR #36564: URL: https://github.com/apache/spark/pull/36564#discussion_r893061431 ## core/src/test/scala/org/apache/spark/scheduler/OutputCommitCoordinatorSuite.scala: ## @@ -187,12 +181,6 @@ class OutputCommitCoordinatorSuite extends SparkFunSuite

[GitHub] [spark] cloud-fan commented on a diff in pull request #36564: [SPARK-39195][SQL] Spark OutputCommitCoordinator should abort stage when committed file not consistent with task status

2022-06-08 Thread GitBox
cloud-fan commented on code in PR #36564: URL: https://github.com/apache/spark/pull/36564#discussion_r893038044 ## core/src/test/scala/org/apache/spark/scheduler/OutputCommitCoordinatorSuite.scala: ## @@ -187,8 +188,8 @@ class OutputCommitCoordinatorSuite extends SparkFunSuite

[GitHub] [spark] cloud-fan commented on a diff in pull request #36564: [SPARK-39195][SQL] Spark OutputCommitCoordinator should abort stage when committed file not consistent with task status

2022-06-08 Thread GitBox
cloud-fan commented on code in PR #36564: URL: https://github.com/apache/spark/pull/36564#discussion_r893037549 ## core/src/main/scala/org/apache/spark/SparkEnv.scala: ## @@ -423,6 +432,7 @@ object SparkEnv extends Logging { envInstance } + // scalastyle:on argcount