[GitHub] [spark] cloud-fan commented on a diff in pull request #38004: [SPARK-40551][SQL] DataSource V2: Add APIs for delta-based row-level operations

2022-11-14 Thread GitBox
cloud-fan commented on code in PR #38004: URL: https://github.com/apache/spark/pull/38004#discussion_r1022327315 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/DeltaWriter.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [spark] cloud-fan commented on a diff in pull request #38004: [SPARK-40551][SQL] DataSource V2: Add APIs for delta-based row-level operations

2022-10-20 Thread GitBox
cloud-fan commented on code in PR #38004: URL: https://github.com/apache/spark/pull/38004#discussion_r1001275080 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/DeltaWriter.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [spark] cloud-fan commented on a diff in pull request #38004: [SPARK-40551][SQL] DataSource V2: Add APIs for delta-based row-level operations

2022-09-28 Thread GitBox
cloud-fan commented on code in PR #38004: URL: https://github.com/apache/spark/pull/38004#discussion_r982053631 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/DeltaWriter.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [spark] cloud-fan commented on a diff in pull request #38004: [SPARK-40551][SQL] DataSource V2: Add APIs for delta-based row-level operations

2022-09-28 Thread GitBox
cloud-fan commented on code in PR #38004: URL: https://github.com/apache/spark/pull/38004#discussion_r982048790 ## sql/catalyst/src/main/scala/org/apache/spark/sql/connector/write/LogicalWriteInfoImpl.scala: ## @@ -23,4 +23,6 @@ import org.apache.spark.sql.util.CaseInsensitiveSt

[GitHub] [spark] cloud-fan commented on a diff in pull request #38004: [SPARK-40551][SQL] DataSource V2: Add APIs for delta-based row-level operations

2022-09-28 Thread GitBox
cloud-fan commented on code in PR #38004: URL: https://github.com/apache/spark/pull/38004#discussion_r982037071 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/LogicalWriteInfo.java: ## @@ -45,4 +45,18 @@ public interface LogicalWriteInfo { * the schema of