[GitHub] [spark] cloud-fan commented on pull request #30421: [SPARK-33474][SQL] Support TypeConstructed partition spec value

2021-03-01 Thread GitBox
cloud-fan commented on pull request #30421: URL: https://github.com/apache/spark/pull/30421#issuecomment-787808014 I don't think we want to have different partition related behaviors for DS v2. If you see an inconsistency, it's probably a bug. > can't use interval as table schema?

[GitHub] [spark] cloud-fan commented on pull request #30421: [SPARK-33474][SQL] Support TypeConstructed partition spec value

2020-11-25 Thread GitBox
cloud-fan commented on pull request #30421: URL: https://github.com/apache/spark/pull/30421#issuecomment-73404 Let's do it step by step, and support typed literal first. We can figure out how to eliminate the string <-> actual value roundtrip in v2 commands later. Let's make

[GitHub] [spark] cloud-fan commented on pull request #30421: [SPARK-33474][SQL] Support TypeConstructed partition spec value

2020-11-24 Thread GitBox
cloud-fan commented on pull request #30421: URL: https://github.com/apache/spark/pull/30421#issuecomment-733429639 Let's revisit the entire process: 1. the parser creates partition spec which is `Map[String, String]` 2. for v1 commands, we pass `Map[String, String]` to hive APIs.

[GitHub] [spark] cloud-fan commented on pull request #30421: [SPARK-33474][SQL] Support TypeConstructed partition spec value

2020-11-24 Thread GitBox
cloud-fan commented on pull request #30421: URL: https://github.com/apache/spark/pull/30421#issuecomment-733425083 cc @MaxGekk This is an automated message from the Apache Git Service. To respond to the message, please log