[GitHub] [spark] cloud-fan commented on pull request #32987: [SPARK-35564][SQL] Support subexpression elimination for conditionally evaluated expressions

2023-03-30 Thread via GitHub
cloud-fan commented on PR #32987: URL: https://github.com/apache/spark/pull/32987#issuecomment-1491247967 After taking another thought, I think the idea is valid. If a subexpression will be evaluated at least once, and likely more than once due to conditional branches, it should be benefici

[GitHub] [spark] cloud-fan commented on pull request #32987: [SPARK-35564][SQL] Support subexpression elimination for conditionally evaluated expressions

2022-09-26 Thread GitBox
cloud-fan commented on PR #32987: URL: https://github.com/apache/spark/pull/32987#issuecomment-1258168996 I don't have a good idea about how to fix this issue. Assume a subexpression appears in both a normal branch and a conditional branch: 1. The condition branch may never be hit at runt

[GitHub] [spark] cloud-fan commented on pull request #32987: [SPARK-35564][SQL] Support subexpression elimination for conditionally evaluated expressions

2021-06-22 Thread GitBox
cloud-fan commented on pull request #32987: URL: https://github.com/apache/spark/pull/32987#issuecomment-866001630 OK to test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment