[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39280: [SPARK-41766][CORE] Handle decommission request sent before executor registration

2023-04-07 Thread via GitHub
dongjoon-hyun commented on code in PR #39280: URL: https://github.com/apache/spark/pull/39280#discussion_r1160945224 ## core/src/main/scala/org/apache/spark/internal/config/package.scala: ## @@ -2242,6 +2242,16 @@ package object config { .checkValue(_ >= 0, "needs to be a

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39280: [SPARK-41766][CORE] Handle decommission request sent before executor registration

2023-04-06 Thread via GitHub
dongjoon-hyun commented on code in PR #39280: URL: https://github.com/apache/spark/pull/39280#discussion_r1160035944 ## core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala: ## @@ -102,6 +103,15 @@ class CoarseGrainedSchedulerBackend(schedul

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39280: [SPARK-41766][CORE] Handle decommission request sent before executor registration

2023-04-06 Thread via GitHub
dongjoon-hyun commented on code in PR #39280: URL: https://github.com/apache/spark/pull/39280#discussion_r1160035944 ## core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala: ## @@ -102,6 +103,15 @@ class CoarseGrainedSchedulerBackend(schedul

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39280: [SPARK-41766][CORE] Handle decommission request sent before executor registration

2022-12-29 Thread GitBox
dongjoon-hyun commented on code in PR #39280: URL: https://github.com/apache/spark/pull/39280#discussion_r1059223633 ## core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala: ## @@ -53,6 +53,8 @@ private[spark] class CoarseGrainedSchedulerBa

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39280: [SPARK-41766][CORE] Handle decommission request sent before executor registration

2022-12-29 Thread GitBox
dongjoon-hyun commented on code in PR #39280: URL: https://github.com/apache/spark/pull/39280#discussion_r1059223443 ## core/src/test/scala/org/apache/spark/scheduler/CoarseGrainedSchedulerBackendSuite.scala: ## @@ -403,6 +404,30 @@ class CoarseGrainedSchedulerBackendSuite exten

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39280: [SPARK-41766][CORE] Handle decommission request sent before executor registration

2022-12-29 Thread GitBox
dongjoon-hyun commented on code in PR #39280: URL: https://github.com/apache/spark/pull/39280#discussion_r1059223400 ## core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala: ## @@ -102,6 +104,15 @@ class CoarseGrainedSchedulerBackend(schedul

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39280: [SPARK-41766][CORE] Handle decommission request sent before executor registration

2022-12-29 Thread GitBox
dongjoon-hyun commented on code in PR #39280: URL: https://github.com/apache/spark/pull/39280#discussion_r1059223050 ## core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala: ## @@ -102,6 +104,15 @@ class CoarseGrainedSchedulerBackend(schedul