[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #43059: [SPARK-45281][CORE][TESTS] Update BenchmarkBase to use Java 17 as the base version

2023-09-22 Thread via GitHub
dongjoon-hyun commented on code in PR #43059: URL: https://github.com/apache/spark/pull/43059#discussion_r1334634163 ## core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala: ## @@ -51,7 +51,7 @@ abstract class BenchmarkBase { val regenerateBenchmarkFiles:

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #43059: [SPARK-45281][CORE][TESTS] Update BenchmarkBase to use Java 17 as the base version

2023-09-22 Thread via GitHub
dongjoon-hyun commented on code in PR #43059: URL: https://github.com/apache/spark/pull/43059#discussion_r1334632610 ## core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala: ## @@ -51,7 +51,7 @@ abstract class BenchmarkBase { val regenerateBenchmarkFiles:

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #43059: [SPARK-45281][CORE][TESTS] Update BenchmarkBase to use Java 17 as the base version

2023-09-22 Thread via GitHub
dongjoon-hyun commented on code in PR #43059: URL: https://github.com/apache/spark/pull/43059#discussion_r1334631707 ## core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala: ## @@ -51,7 +51,7 @@ abstract class BenchmarkBase { val regenerateBenchmarkFiles:

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #43059: [SPARK-45281][CORE][TESTS] Update BenchmarkBase to use Java 17 as the base version

2023-09-22 Thread via GitHub
dongjoon-hyun commented on code in PR #43059: URL: https://github.com/apache/spark/pull/43059#discussion_r1334629527 ## core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala: ## @@ -51,7 +51,7 @@ abstract class BenchmarkBase { val regenerateBenchmarkFiles: