eejbyfeldt commented on PR #41943:
URL: https://github.com/apache/spark/pull/41943#issuecomment-1720762469
Closing this as it no longer relevant. In the 3.5 scala 2.13 was downgraded
and the update will be done in https://github.com/apache/spark/pull/42918
--
This is an automated message
eejbyfeldt commented on PR #41943:
URL: https://github.com/apache/spark/pull/41943#issuecomment-1661617217
> Assuming that a Java 8 build works on Java 17.
The problem is that this does not work with the current code as building
with `-release 8` will for bid access to the classes in
eejbyfeldt commented on PR #41943:
URL: https://github.com/apache/spark/pull/41943#issuecomment-1659753792
> change -target:jvm-1.8 to -release:8, both line 2911 and line 3652
Hardcoding `-release:8` with the new default activation will not actually
setting the `-release` config to
eejbyfeldt commented on PR #41943:
URL: https://github.com/apache/spark/pull/41943#issuecomment-1658336924
> I think the issue is you will target Java 17 bytecode if running on 17,
when we want to target 8 in all cases
If that is the case then the changes currently in this PR are not
eejbyfeldt commented on PR #41943:
URL: https://github.com/apache/spark/pull/41943#issuecomment-1658031228
> Is this suggestion works? If it works, we don't need to manually specify
-Djava.version=?
Added it to this PR. Seems to work based on my testing locally.
I did not add
eejbyfeldt commented on PR #41943:
URL: https://github.com/apache/spark/pull/41943#issuecomment-1657900414
Anyone opinions how we should proceed with this? Would be nice to have this
fixed in the 3.5 branch as not being able to build with java 11 or newer is a
regression compared to
eejbyfeldt commented on PR #41943:
URL: https://github.com/apache/spark/pull/41943#issuecomment-1632687298
> I think the issue is that you end up compiling against a later version of
JDK > If this change works for Java 8 and later, it seems fine.
There are still issues compiling 2.13
eejbyfeldt commented on PR #41943:
URL: https://github.com/apache/spark/pull/41943#issuecomment-1631892085
> @eejbyfeldt Do you know why SBT is not failed?
The failures are not directly related to scala 2.13.11. They are caused by
the maven plugin we are using for running scalac. For
