[GitHub] [spark] gengliangwang commented on a diff in pull request #36812: [SPARK-39419][SQL] Fix ArraySort to throw an exception when the comparator returns null

2022-06-08 Thread GitBox
gengliangwang commented on code in PR #36812: URL: https://github.com/apache/spark/pull/36812#discussion_r893036298 ## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ## @@ -3828,6 +3828,15 @@ object SQLConf { .booleanConf

[GitHub] [spark] gengliangwang commented on a diff in pull request #36812: [SPARK-39419][SQL] Fix ArraySort to throw an exception when the comparator returns null

2022-06-08 Thread GitBox
gengliangwang commented on code in PR #36812: URL: https://github.com/apache/spark/pull/36812#discussion_r892996318 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala: ## @@ -375,9 +375,17 @@ case class ArrayTransform( //

[GitHub] [spark] gengliangwang commented on a diff in pull request #36812: [SPARK-39419][SQL] Fix ArraySort to throw an exception when the comparator returns null

2022-06-08 Thread GitBox
gengliangwang commented on code in PR #36812: URL: https://github.com/apache/spark/pull/36812#discussion_r892992649 ## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ## @@ -3828,6 +3828,15 @@ object SQLConf { .booleanConf