[GitHub] [spark] igozali commented on issue #25910: [SPARK-28762][CORE] Read JAR main class if JAR is not located in local file system

2019-10-17 Thread GitBox
igozali commented on issue #25910: [SPARK-28762][CORE] Read JAR main class if JAR is not located in local file system URL: https://github.com/apache/spark/pull/25910#issuecomment-543372528 Thanks @vanzin @srowen @dongjoon-hyun for all of your help!

[GitHub] [spark] igozali commented on issue #25910: [SPARK-28762][CORE] Read JAR main class if JAR is not located in local file system

2019-10-15 Thread GitBox
igozali commented on issue #25910: [SPARK-28762][CORE] Read JAR main class if JAR is not located in local file system URL: https://github.com/apache/spark/pull/25910#issuecomment-542363360 @srowen @vanzin I've updated my approach, would like to see if this is more along the lines of what

[GitHub] [spark] igozali commented on issue #25910: [SPARK-28762][CORE] Read JAR main class if JAR is not located in local file system

2019-09-26 Thread GitBox
igozali commented on issue #25910: [SPARK-28762][CORE] Read JAR main class if JAR is not located in local file system URL: https://github.com/apache/spark/pull/25910#issuecomment-535568927 Hi @srowen, thanks for taking the time to give a review. For your last comment, if I try to keep as

[GitHub] [spark] igozali commented on issue #25910: [SPARK-28762][CORE] Read JAR main class if JAR is not located in local file system

2019-09-24 Thread GitBox
igozali commented on issue #25910: [SPARK-28762][CORE] Read JAR main class if JAR is not located in local file system URL: https://github.com/apache/spark/pull/25910#issuecomment-534622636 No problem, thanks for taking a look @dongjoon-hyun. I was wondering if the approach is ok and