[GitHub] [spark] itholic commented on a diff in pull request #42938: [SPARK-44788][CONNECT][PYTHON][SQL] Add from_xml and schema_of_xml to pyspark, spark connect and sql function

2023-09-16 Thread via GitHub
itholic commented on code in PR #42938: URL: https://github.com/apache/spark/pull/42938#discussion_r1327925718 ## python/pyspark/sql/tests/test_functions.py: ## @@ -1286,6 +1281,27 @@ def test_from_csv(self): message_parameters={"arg_name": "schema", "arg_type": "in

[GitHub] [spark] itholic commented on a diff in pull request #42938: [SPARK-44788][CONNECT][PYTHON][SQL] Add from_xml and schema_of_xml to pyspark, spark connect and sql function

2023-09-16 Thread via GitHub
itholic commented on code in PR #42938: URL: https://github.com/apache/spark/pull/42938#discussion_r1327925718 ## python/pyspark/sql/tests/test_functions.py: ## @@ -1286,6 +1281,27 @@ def test_from_csv(self): message_parameters={"arg_name": "schema", "arg_type": "in

[GitHub] [spark] itholic commented on a diff in pull request #42938: [SPARK-44788][CONNECT][PYTHON][SQL] Add from_xml and schema_of_xml to pyspark, spark connect and sql function

2023-09-16 Thread via GitHub
itholic commented on code in PR #42938: URL: https://github.com/apache/spark/pull/42938#discussion_r1327925718 ## python/pyspark/sql/tests/test_functions.py: ## @@ -1286,6 +1281,27 @@ def test_from_csv(self): message_parameters={"arg_name": "schema", "arg_type": "in

[GitHub] [spark] itholic commented on a diff in pull request #42938: [SPARK-44788][CONNECT][PYTHON][SQL] Add from_xml and schema_of_xml to pyspark, spark connect and sql function

2023-09-16 Thread via GitHub
itholic commented on code in PR #42938: URL: https://github.com/apache/spark/pull/42938#discussion_r1327920967 ## python/pyspark/errors/error_classes.py: ## @@ -477,6 +477,11 @@ "Argument `` should be a Column or str, got ." ] }, + "NOT_COLUMN_OR_STR_OR_STRUCT" :