[GitHub] [spark] jchen5 commented on a diff in pull request #42725: [SPARK-45009][SQL] Decorrelate predicate subqueries in join condition

2023-09-06 Thread via GitHub
jchen5 commented on code in PR #42725: URL: https://github.com/apache/spark/pull/42725#discussion_r1317574577 ## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ## @@ -4387,6 +4387,15 @@ object SQLConf { .booleanConf .createWithDefault(true

[GitHub] [spark] jchen5 commented on a diff in pull request #42725: [SPARK-45009][SQL] Decorrelate predicate subqueries in join condition

2023-08-30 Thread via GitHub
jchen5 commented on code in PR #42725: URL: https://github.com/apache/spark/pull/42725#discussion_r1310660553 ## sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala: ## @@ -3751,4 +3751,14 @@ private[sql] object QueryCompilationErrors extends Qu

[GitHub] [spark] jchen5 commented on a diff in pull request #42725: [SPARK-45009][SQL] Decorrelate predicate subqueries in join condition

2023-08-29 Thread via GitHub
jchen5 commented on code in PR #42725: URL: https://github.com/apache/spark/pull/42725#discussion_r1309347387 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala: ## @@ -158,6 +159,50 @@ object RewritePredicateSubquery extends Rule[LogicalPlan]