[GitHub] [spark] kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour

2019-10-25 Thread GitBox
kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#discussion_r338935434 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.

[GitHub] [spark] kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour

2019-10-25 Thread GitBox
kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#discussion_r338934735 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.

[GitHub] [spark] kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour

2019-10-25 Thread GitBox
kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#discussion_r338931246 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.

[GitHub] [spark] kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour

2019-10-25 Thread GitBox
kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#discussion_r338927347 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressions

[GitHub] [spark] kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour

2019-09-26 Thread GitBox
kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#discussion_r328723965 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.

[GitHub] [spark] kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour

2019-09-26 Thread GitBox
kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#discussion_r328722377 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.

[GitHub] [spark] kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour

2019-09-26 Thread GitBox
kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#discussion_r328722232 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ## @@

[GitHub] [spark] kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour

2019-09-26 Thread GitBox
kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#discussion_r328722053 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressions

[GitHub] [spark] kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour

2019-09-18 Thread GitBox
kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#discussion_r325846444 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.

[GitHub] [spark] kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour

2019-09-18 Thread GitBox
kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#discussion_r325806023 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala

[GitHub] [spark] kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour

2019-09-18 Thread GitBox
kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#discussion_r325806391 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.

[GitHub] [spark] kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour

2019-09-18 Thread GitBox
kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#discussion_r325806023 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala

[GitHub] [spark] kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour

2019-09-18 Thread GitBox
kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#discussion_r325806135 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.

[GitHub] [spark] kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour

2019-09-15 Thread GitBox
kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#discussion_r324499435 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ## @@

[GitHub] [spark] kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour

2019-09-15 Thread GitBox
kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#discussion_r324499400 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ## @@