[GitHub] [spark] leanken commented on a change in pull request #30442: [SPARK-33498][SQL] Datetime parsing should fail if the input string can't be parsed, or the pattern string is invalid

2020-11-26 Thread GitBox
leanken commented on a change in pull request #30442: URL: https://github.com/apache/spark/pull/30442#discussion_r531412245 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala ## @@ -945,6 +934,36 @@ abstract class AnsiCastSuiteB

[GitHub] [spark] leanken commented on a change in pull request #30442: [SPARK-33498][SQL] Datetime parsing should fail if the input string can't be parsed, or the pattern string is invalid

2020-11-26 Thread GitBox
leanken commented on a change in pull request #30442: URL: https://github.com/apache/spark/pull/30442#discussion_r530904343 ## File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/window_part3.sql.out ## @@ -71,7 +71,8 @@ insert into datetimes values -- !query