[GitHub] [spark] leanken edited a comment on pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-24 Thread GitBox
leanken edited a comment on pull request #29104: URL: https://github.com/apache/spark/pull/29104#issuecomment-663787183 @agrawaldevesh Thanks for your great help during the review. And i will make sure that the BHJ is not regressed by this change.

[GitHub] [spark] leanken edited a comment on pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-24 Thread GitBox
leanken edited a comment on pull request #29104: URL: https://github.com/apache/spark/pull/29104#issuecomment-663787183 @agrawaldevesh Thanks for your great help during the review. And i sure will make sure that the BHJ is not regressed by this change.

[GitHub] [spark] leanken edited a comment on pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-20 Thread GitBox
leanken edited a comment on pull request #29104: URL: https://github.com/apache/spark/pull/29104#issuecomment-661586173 @agrawaldevesh @cloud-fan for BroadcasthashJoinExec, how about this ``` if (isNullAwareAntiJoin) { require(leftKeys.length == 1, "leftKeys length should

[GitHub] [spark] leanken edited a comment on pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-20 Thread GitBox
leanken edited a comment on pull request #29104: URL: https://github.com/apache/spark/pull/29104#issuecomment-660991285 @agrawaldevesh @maropu @cloud-fan Update digest as follow. 1. update HashedRelation to carry inputEmpty and anyNullKeyExists information 2.