[GitHub] [spark] ueshin commented on a diff in pull request #42371: [SPARK-44694][PYTHON][CONNECT] Refactor active sessions and expose them as an API

2023-08-07 Thread via GitHub
ueshin commented on code in PR #42371: URL: https://github.com/apache/spark/pull/42371#discussion_r1286461234 ## python/pyspark/sql/connect/session.py: ## @@ -93,14 +94,13 @@ from pyspark.sql.connect.udtf import UDTFRegistration -# `_active_spark_session` stores the

[GitHub] [spark] ueshin commented on a diff in pull request #42371: [SPARK-44694][PYTHON][CONNECT] Refactor active sessions and expose them as an API

2023-08-07 Thread via GitHub
ueshin commented on code in PR #42371: URL: https://github.com/apache/spark/pull/42371#discussion_r1286461234 ## python/pyspark/sql/connect/session.py: ## @@ -93,14 +94,13 @@ from pyspark.sql.connect.udtf import UDTFRegistration -# `_active_spark_session` stores the

[GitHub] [spark] ueshin commented on a diff in pull request #42371: [SPARK-44694][PYTHON][CONNECT] Refactor active sessions and expose them as an API

2023-08-07 Thread via GitHub
ueshin commented on code in PR #42371: URL: https://github.com/apache/spark/pull/42371#discussion_r1286461234 ## python/pyspark/sql/connect/session.py: ## @@ -93,14 +94,13 @@ from pyspark.sql.connect.udtf import UDTFRegistration -# `_active_spark_session` stores the

[GitHub] [spark] ueshin commented on a diff in pull request #42371: [SPARK-44694][PYTHON][CONNECT] Refactor active sessions and expose them as an API

2023-08-07 Thread via GitHub
ueshin commented on code in PR #42371: URL: https://github.com/apache/spark/pull/42371#discussion_r1286422331 ## python/pyspark/sql/connect/session.py: ## @@ -93,14 +94,13 @@ from pyspark.sql.connect.udtf import UDTFRegistration -# `_active_spark_session` stores the

[GitHub] [spark] ueshin commented on a diff in pull request #42371: [SPARK-44694][PYTHON][CONNECT] Refactor active sessions and expose them as an API

2023-08-07 Thread via GitHub
ueshin commented on code in PR #42371: URL: https://github.com/apache/spark/pull/42371#discussion_r1286413587 ## python/pyspark/sql/connect/session.py: ## @@ -628,20 +664,18 @@ def is_stopped(self) -> bool: """ return self.client.is_closed -@classmethod