[GitHub] [spark] viirya commented on a change in pull request #33239: [SPARK-36030][SQL] Support DS v2 metrics at writing path

viirya commented on a change in pull request #33239: URL: https://github.com/apache/spark/pull/33239#discussion_r672584143 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala ## @@ -852,6 +857,33 @@ class

[GitHub] [spark] viirya commented on a change in pull request #33239: [SPARK-36030][SQL] Support DS v2 metrics at writing path

viirya commented on a change in pull request #33239: URL: https://github.com/apache/spark/pull/33239#discussion_r672584143 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala ## @@ -852,6 +857,33 @@ class

[GitHub] [spark] viirya commented on a change in pull request #33239: [SPARK-36030][SQL] Support DS v2 metrics at writing path

viirya commented on a change in pull request #33239: URL: https://github.com/apache/spark/pull/33239#discussion_r672884741 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileFormatDataWriterMetricSuite.scala ## @@ -0,0 +1,96 @@ +/* + *

[GitHub] [spark] viirya commented on a change in pull request #33239: [SPARK-36030][SQL] Support DS v2 metrics at writing path

viirya commented on a change in pull request #33239: URL: https://github.com/apache/spark/pull/33239#discussion_r672846173 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatDataWriter.scala ## @@ -79,9 +81,15 @@ abstract class

[GitHub] [spark] viirya commented on a change in pull request #33239: [SPARK-36030][SQL] Support DS v2 metrics at writing path

viirya commented on a change in pull request #33239: URL: https://github.com/apache/spark/pull/33239#discussion_r672832410 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/metric/CustomMetrics.scala ## @@ -51,7 +51,7 @@ object CustomMetrics {

[GitHub] [spark] viirya commented on a change in pull request #33239: [SPARK-36030][SQL] Support DS v2 metrics at writing path

viirya commented on a change in pull request #33239: URL: https://github.com/apache/spark/pull/33239#discussion_r672812727 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/metric/CustomMetrics.scala ## @@ -51,7 +51,7 @@ object CustomMetrics {

[GitHub] [spark] viirya commented on a change in pull request #33239: [SPARK-36030][SQL] Support DS v2 metrics at writing path

viirya commented on a change in pull request #33239: URL: https://github.com/apache/spark/pull/33239#discussion_r672812642 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileFormatDataWriterMetricSuite.scala ## @@ -0,0 +1,96 @@ +/* + *

[GitHub] [spark] viirya commented on a change in pull request #33239: [SPARK-36030][SQL] Support DS v2 metrics at writing path

viirya commented on a change in pull request #33239: URL: https://github.com/apache/spark/pull/33239#discussion_r672793126 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatDataWriter.scala ## @@ -41,7 +42,8 @@ import

[GitHub] [spark] viirya commented on a change in pull request #33239: [SPARK-36030][SQL] Support DS v2 metrics at writing path

viirya commented on a change in pull request #33239: URL: https://github.com/apache/spark/pull/33239#discussion_r672660474 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatDataWriter.scala ## @@ -41,7 +42,8 @@ import

[GitHub] [spark] viirya commented on a change in pull request #33239: [SPARK-36030][SQL] Support DS v2 metrics at writing path

viirya commented on a change in pull request #33239: URL: https://github.com/apache/spark/pull/33239#discussion_r672584143 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala ## @@ -852,6 +857,33 @@ class