zero323 commented on a change in pull request #29591:
URL: https://github.com/apache/spark/pull/29591#discussion_r489509397
##
File path: python/pyspark/sql/pandas/_typing/protocols/series.pyi
##
@@ -0,0 +1,253 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under
zero323 commented on a change in pull request #29591:
URL: https://github.com/apache/spark/pull/29591#discussion_r489419328
##
File path: python/pyspark/sql/types.pyi
##
@@ -0,0 +1,220 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
zero323 commented on a change in pull request #29591:
URL: https://github.com/apache/spark/pull/29591#discussion_r489419177
##
File path: python/pyspark/sql/pandas/_typing/protocols/series.pyi
##
@@ -0,0 +1,253 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under
zero323 commented on a change in pull request #29591:
URL: https://github.com/apache/spark/pull/29591#discussion_r489410868
##
File path: python/pyspark/sql/column.pyi
##
@@ -0,0 +1,111 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
zero323 commented on a change in pull request #29591:
URL: https://github.com/apache/spark/pull/29591#discussion_r489409917
##
File path: python/pyspark/__init__.pyi
##
@@ -0,0 +1,73 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
zero323 commented on a change in pull request #29591:
URL: https://github.com/apache/spark/pull/29591#discussion_r489407052
##
File path: python/pyspark/py.typed
##
@@ -0,0 +1 @@
+partial
Review comment:
In case of stub packages this allows us to skip annotations for
zero323 commented on a change in pull request #29591:
URL: https://github.com/apache/spark/pull/29591#discussion_r489406537
##
File path: python/pyspark/__init__.pyi
##
@@ -0,0 +1,73 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
zero323 commented on a change in pull request #29591:
URL: https://github.com/apache/spark/pull/29591#discussion_r489402579
##
File path: python/pyspark/ml/evaluation.pyi
##
@@ -0,0 +1,283 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
zero323 commented on a change in pull request #29591:
URL: https://github.com/apache/spark/pull/29591#discussion_r487129652
##
File path: dev/tox.ini
##
@@ -20,5 +20,5 @@
exclude=python/pyspark/cloudpickle/*.py,shared.py,python/docs/source/conf.py,wor
[flake8]
select =
zero323 commented on a change in pull request #29591:
URL: https://github.com/apache/spark/pull/29591#discussion_r487129652
##
File path: dev/tox.ini
##
@@ -20,5 +20,5 @@
exclude=python/pyspark/cloudpickle/*.py,shared.py,python/docs/source/conf.py,wor
[flake8]
select =
zero323 commented on a change in pull request #29591:
URL: https://github.com/apache/spark/pull/29591#discussion_r487129652
##
File path: dev/tox.ini
##
@@ -20,5 +20,5 @@
exclude=python/pyspark/cloudpickle/*.py,shared.py,python/docs/source/conf.py,wor
[flake8]
select =
zero323 commented on a change in pull request #29591:
URL: https://github.com/apache/spark/pull/29591#discussion_r487129652
##
File path: dev/tox.ini
##
@@ -20,5 +20,5 @@
exclude=python/pyspark/cloudpickle/*.py,shared.py,python/docs/source/conf.py,wor
[flake8]
select =
zero323 commented on a change in pull request #29591:
URL: https://github.com/apache/spark/pull/29591#discussion_r486428984
##
File path: examples/src/main/python/sql/arrow.py
##
@@ -32,8 +32,8 @@
def dataframe_with_arrow_example(spark):
-import numpy as np
-
zero323 commented on a change in pull request #29591:
URL: https://github.com/apache/spark/pull/29591#discussion_r486428984
##
File path: examples/src/main/python/sql/arrow.py
##
@@ -32,8 +32,8 @@
def dataframe_with_arrow_example(spark):
-import numpy as np
-
zero323 commented on a change in pull request #29591:
URL: https://github.com/apache/spark/pull/29591#discussion_r486399441
##
File path: python/pyspark/context.pyi
##
@@ -0,0 +1,179 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
zero323 commented on a change in pull request #29591:
URL: https://github.com/apache/spark/pull/29591#discussion_r486075857
##
File path: python/pyspark/ml/tests/test_algorithms.py
##
@@ -333,7 +333,7 @@ def test_linear_regression_with_huber_loss(self):
from
zero323 commented on a change in pull request #29591:
URL: https://github.com/apache/spark/pull/29591#discussion_r486075570
##
File path: python/pyspark/ml/common.pyi
##
@@ -0,0 +1,27 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
zero323 commented on a change in pull request #29591:
URL: https://github.com/apache/spark/pull/29591#discussion_r484560092
##
File path: python/MANIFEST.in
##
@@ -22,4 +22,5 @@ recursive-include deps/data *.data *.txt
recursive-include deps/licenses *.txt
recursive-include
zero323 commented on a change in pull request #29591:
URL: https://github.com/apache/spark/pull/29591#discussion_r484200653
##
File path: examples/src/main/python/ml/estimator_transformer_param_example.py
##
@@ -54,7 +56,7 @@
print(model1.extractParamMap())
# We
zero323 commented on a change in pull request #29591:
URL: https://github.com/apache/spark/pull/29591#discussion_r484200753
##
File path: dev/tox.ini
##
@@ -20,5 +20,16 @@
exclude=python/pyspark/cloudpickle/*.py,shared.py,python/docs/source/conf.py,wor
[flake8]
select =
zero323 commented on a change in pull request #29591:
URL: https://github.com/apache/spark/pull/29591#discussion_r484184260
##
File path: examples/src/main/python/ml/estimator_transformer_param_example.py
##
@@ -54,7 +56,7 @@
print(model1.extractParamMap())
# We
zero323 commented on a change in pull request #29591:
URL: https://github.com/apache/spark/pull/29591#discussion_r480272293
##
File path: python/pyspark/cloudpickle.pyi
##
@@ -0,0 +1,86 @@
+#
Review comment:
> I believe this file can be removed
Indeed, thanks!
22 matches
Mail list logo
