[GitHub] [spark] zero323 commented on a change in pull request #34513: [SPARK-37234][PYTHON] Inline type hints for python/pyspark/mllib/stat/_statistics.py

2022-03-06 Thread GitBox
zero323 commented on a change in pull request #34513: URL: https://github.com/apache/spark/pull/34513#discussion_r820245641 ## File path: python/pyspark/mllib/_typing.pyi ## @@ -17,10 +17,16 @@ # under the License. from typing import List, Tuple, TypeVar, Union + +from

[GitHub] [spark] zero323 commented on a change in pull request #34513: [SPARK-37234][PYTHON] Inline type hints for python/pyspark/mllib/stat/_statistics.py

2021-11-25 Thread GitBox
zero323 commented on a change in pull request #34513: URL: https://github.com/apache/spark/pull/34513#discussion_r756794845 ## File path: python/pyspark/mllib/stat/_statistics.py ## @@ -168,12 +190,34 @@ def corr(x, y=None, method=None): raise TypeError("Use

[GitHub] [spark] zero323 commented on a change in pull request #34513: [SPARK-37234][PYTHON] Inline type hints for python/pyspark/mllib/stat/_statistics.py

2021-11-25 Thread GitBox
zero323 commented on a change in pull request #34513: URL: https://github.com/apache/spark/pull/34513#discussion_r756781924 ## File path: python/pyspark/mllib/stat/_statistics.py ## @@ -168,12 +190,34 @@ def corr(x, y=None, method=None): raise TypeError("Use

[GitHub] [spark] zero323 commented on a change in pull request #34513: [SPARK-37234][PYTHON] Inline type hints for python/pyspark/mllib/stat/_statistics.py

2021-11-23 Thread GitBox
zero323 commented on a change in pull request #34513: URL: https://github.com/apache/spark/pull/34513#discussion_r755596954 ## File path: python/pyspark/mllib/stat/_statistics.py ## @@ -170,10 +190,29 @@ def corr(x, y=None, method=None): if not y: return

[GitHub] [spark] zero323 commented on a change in pull request #34513: [SPARK-37234][PYTHON] Inline type hints for python/pyspark/mllib/stat/_statistics.py

2021-11-21 Thread GitBox
zero323 commented on a change in pull request #34513: URL: https://github.com/apache/spark/pull/34513#discussion_r753783981 ## File path: python/pyspark/mllib/linalg/__init__.pyi ## @@ -68,6 +68,7 @@ class Vector: __UDT__: VectorUDT def toArray(self) -> ndarray: ...

[GitHub] [spark] zero323 commented on a change in pull request #34513: [SPARK-37234][PYTHON] Inline type hints for python/pyspark/mllib/stat/_statistics.py

2021-11-21 Thread GitBox
zero323 commented on a change in pull request #34513: URL: https://github.com/apache/spark/pull/34513#discussion_r753808683 ## File path: python/pyspark/mllib/linalg/__init__.pyi ## @@ -68,6 +68,7 @@ class Vector: __UDT__: VectorUDT def toArray(self) -> ndarray: ...

[GitHub] [spark] zero323 commented on a change in pull request #34513: [SPARK-37234][PYTHON] Inline type hints for python/pyspark/mllib/stat/_statistics.py

2021-11-21 Thread GitBox
zero323 commented on a change in pull request #34513: URL: https://github.com/apache/spark/pull/34513#discussion_r753786802 ## File path: python/pyspark/mllib/stat/_statistics.py ## @@ -16,51 +16,57 @@ # import sys +from typing import overload, List, Optional, Union +from

[GitHub] [spark] zero323 commented on a change in pull request #34513: [SPARK-37234][PYTHON] Inline type hints for python/pyspark/mllib/stat/_statistics.py

2021-11-21 Thread GitBox
zero323 commented on a change in pull request #34513: URL: https://github.com/apache/spark/pull/34513#discussion_r753786672 ## File path: python/pyspark/mllib/stat/_statistics.py ## @@ -16,51 +16,57 @@ # import sys +from typing import overload, List, Optional, Union +from

[GitHub] [spark] zero323 commented on a change in pull request #34513: [SPARK-37234][PYTHON] Inline type hints for python/pyspark/mllib/stat/_statistics.py

2021-11-21 Thread GitBox
zero323 commented on a change in pull request #34513: URL: https://github.com/apache/spark/pull/34513#discussion_r753784312 ## File path: python/pyspark/mllib/stat/_statistics.py ## @@ -170,10 +190,29 @@ def corr(x, y=None, method=None): if not y: return

[GitHub] [spark] zero323 commented on a change in pull request #34513: [SPARK-37234][PYTHON] Inline type hints for python/pyspark/mllib/stat/_statistics.py

2021-11-21 Thread GitBox
zero323 commented on a change in pull request #34513: URL: https://github.com/apache/spark/pull/34513#discussion_r753784172 ## File path: python/pyspark/mllib/stat/_statistics.py ## @@ -170,10 +190,29 @@ def corr(x, y=None, method=None): if not y: return

[GitHub] [spark] zero323 commented on a change in pull request #34513: [SPARK-37234][PYTHON] Inline type hints for python/pyspark/mllib/stat/_statistics.py

2021-11-21 Thread GitBox
zero323 commented on a change in pull request #34513: URL: https://github.com/apache/spark/pull/34513#discussion_r753783981 ## File path: python/pyspark/mllib/linalg/__init__.pyi ## @@ -68,6 +68,7 @@ class Vector: __UDT__: VectorUDT def toArray(self) -> ndarray: ...