[GitHub] [spark] zero323 commented on pull request #30413: [SPARK-33252][PYTHON][DOCS] Migration to NumPy documentation style in MLlib (pyspark.mllib.*)

2020-11-25 Thread GitBox
zero323 commented on pull request #30413: URL: https://github.com/apache/spark/pull/30413#issuecomment-733565168 Thanks everyone! This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] zero323 commented on pull request #30413: [SPARK-33252][PYTHON][DOCS] Migration to NumPy documentation style in MLlib (pyspark.mllib.*)

2020-11-25 Thread GitBox
zero323 commented on pull request #30413: URL: https://github.com/apache/spark/pull/30413#issuecomment-733564631 > @zero323, the only reason I have chosen `cols` over `*cols` is that I felt odds to just document this such as `*cols : tuple`, and thought `` cols: str, :class:`Column` ... ``

[GitHub] [spark] zero323 commented on pull request #30413: [SPARK-33252][PYTHON][DOCS] Migration to NumPy documentation style in MLlib (pyspark.mllib.*)

2020-11-24 Thread GitBox
zero323 commented on pull request #30413: URL: https://github.com/apache/spark/pull/30413#issuecomment-733328865 __Side note__ @HyukjinKwon > Looking at [`numpy.ndarray.item`](https://numpy.org/devdocs/reference/generated/numpy.ndarray.item.html) we should make varargs expli

[GitHub] [spark] zero323 commented on pull request #30413: [SPARK-33252][PYTHON][DOCS] Migration to NumPy documentation style in MLlib (pyspark.mllib.*)

2020-11-24 Thread GitBox
zero323 commented on pull request #30413: URL: https://github.com/apache/spark/pull/30413#issuecomment-733108177 > BTW, @zero323 could you please provide some screenshots after this change Done, @zhengruifeng. This is

[GitHub] [spark] zero323 commented on pull request #30413: [SPARK-33252][PYTHON][DOCS] Migration to NumPy documentation style in MLlib (pyspark.mllib.*)

2020-11-23 Thread GitBox
zero323 commented on pull request #30413: URL: https://github.com/apache/spark/pull/30413#issuecomment-732099229 Some examples have been provided by @HyukjinKwon in the initial PR (https://github.com/apache/spark/pull/30149), but I'll try to provide some `mllib`-specific one later, when I