[GitHub] [spark] zhengruifeng commented on a diff in pull request #41505: [SPARK-43938][CONNECT][PYTHON] Add to_* functions to Scala and Python

2023-06-10 Thread via GitHub
zhengruifeng commented on code in PR #41505: URL: https://github.com/apache/spark/pull/41505#discussion_r1225724520 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/functions.scala: ## @@ -3393,6 +3421,81 @@ object functions { */ def upper(e: Column): C

[GitHub] [spark] zhengruifeng commented on a diff in pull request #41505: [SPARK-43938][CONNECT][PYTHON] Add to_* functions to Scala and Python

2023-06-09 Thread via GitHub
zhengruifeng commented on code in PR #41505: URL: https://github.com/apache/spark/pull/41505#discussion_r1225015644 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/functions.scala: ## @@ -3393,6 +3421,81 @@ object functions { */ def upper(e: Column): C

[GitHub] [spark] zhengruifeng commented on a diff in pull request #41505: [SPARK-43938][CONNECT][PYTHON] Add to_* functions to Scala and Python

2023-06-08 Thread via GitHub
zhengruifeng commented on code in PR #41505: URL: https://github.com/apache/spark/pull/41505#discussion_r1223802204 ## connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/PlanGenerationTestSuite.scala: ## @@ -1964,6 +1964,34 @@ class PlanGenerationTestSuite fn.

[GitHub] [spark] zhengruifeng commented on a diff in pull request #41505: [SPARK-43938][CONNECT][PYTHON] Add to_* functions to Scala and Python

2023-06-08 Thread via GitHub
zhengruifeng commented on code in PR #41505: URL: https://github.com/apache/spark/pull/41505#discussion_r1222766865 ## sql/core/src/main/scala/org/apache/spark/sql/functions.scala: ## @@ -5292,6 +5292,183 @@ object functions { */ def hours(e: Column): Column = withExpr {

[GitHub] [spark] zhengruifeng commented on a diff in pull request #41505: [SPARK-43938][CONNECT][PYTHON] Add to_* functions to Scala and Python

2023-06-08 Thread via GitHub
zhengruifeng commented on code in PR #41505: URL: https://github.com/apache/spark/pull/41505#discussion_r1222761412 ## sql/core/src/main/scala/org/apache/spark/sql/functions.scala: ## @@ -5292,6 +5292,183 @@ object functions { */ def hours(e: Column): Column = withExpr {

[GitHub] [spark] zhengruifeng commented on a diff in pull request #41505: [SPARK-43938][CONNECT][PYTHON] Add to_* functions to Scala and Python

2023-06-08 Thread via GitHub
zhengruifeng commented on code in PR #41505: URL: https://github.com/apache/spark/pull/41505#discussion_r1222575032 ## python/pyspark/sql/functions.py: ## @@ -9929,6 +10078,26 @@ def map_zip_with( return _invoke_higher_order_function("MapZipWith", [col1, col2], [f]) +de

[GitHub] [spark] zhengruifeng commented on a diff in pull request #41505: [SPARK-43938][CONNECT][PYTHON] Add to_* functions to Scala and Python

2023-06-07 Thread via GitHub
zhengruifeng commented on code in PR #41505: URL: https://github.com/apache/spark/pull/41505#discussion_r1222413891 ## python/pyspark/sql/functions.py: ## @@ -9929,6 +10078,26 @@ def map_zip_with( return _invoke_higher_order_function("MapZipWith", [col1, col2], [f]) +de

[GitHub] [spark] zhengruifeng commented on a diff in pull request #41505: [SPARK-43938][CONNECT][PYTHON] Add to_* functions to Scala and Python

2023-06-07 Thread via GitHub
zhengruifeng commented on code in PR #41505: URL: https://github.com/apache/spark/pull/41505#discussion_r1222410390 ## python/pyspark/sql/functions.py: ## @@ -9929,6 +10078,26 @@ def map_zip_with( return _invoke_higher_order_function("MapZipWith", [col1, col2], [f]) +de

[GitHub] [spark] zhengruifeng commented on a diff in pull request #41505: [SPARK-43938][CONNECT][PYTHON] Add to_* functions to Scala and Python

2023-06-07 Thread via GitHub
zhengruifeng commented on code in PR #41505: URL: https://github.com/apache/spark/pull/41505#discussion_r1222409717 ## python/pyspark/sql/functions.py: ## @@ -9929,6 +10078,26 @@ def map_zip_with( return _invoke_higher_order_function("MapZipWith", [col1, col2], [f]) +de

[GitHub] [spark] zhengruifeng commented on a diff in pull request #41505: [SPARK-43938][CONNECT][PYTHON] Add to_* functions to Scala and Python

2023-06-07 Thread via GitHub
zhengruifeng commented on code in PR #41505: URL: https://github.com/apache/spark/pull/41505#discussion_r1222409417 ## python/pyspark/sql/functions.py: ## @@ -9929,6 +10078,26 @@ def map_zip_with( return _invoke_higher_order_function("MapZipWith", [col1, col2], [f]) +de