Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/13539
@inouehrs Since the solution is kind of hacky, could you close this PR, or
you have some other better solution? Also cc @kiszk
---
If your project is set up for it, you can reply to this email
Github user inouehrs commented on the issue:
https://github.com/apache/spark/pull/13539
@cloud-fan @davies Thank you so much for the comments.
I agree that my implementation is hacky. I tried to do optimization without
adding members in ExprCode or Expression. I look for a less-ha
Github user davies commented on the issue:
https://github.com/apache/spark/pull/13539
As @cloud-fan said, the implementation is hacky, the improvements is not
not obvious (I believe JIT compile do these very well, correct me if I'm
wrong), I'd like not do this. There are millions ways
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13539
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13539
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60412/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13539
**[Test build #60412 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60412/consoleFull)**
for PR 13539 at commit
[`186283e`](https://github.com/apache/spark/commit/
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13539
cc @davies
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13539
This PR seems kind of hacky to me. The optimization in
`GenerateUnsafeProject` which depends on the foldability of generated code is
also hacky. This is something our string based codegen framewor
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13539
**[Test build #60412 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60412/consoleFull)**
for PR 13539 at commit
[`186283e`](https://github.com/apache/spark/commit/1
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13539
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if t
Github user inouehrs commented on the issue:
https://github.com/apache/spark/pull/13539
@rxin could you please review this pull request (or please suggest someone
I should ask for the review)?
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/13539
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13539
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
13 matches
Mail list logo
