[GitHub] spark issue #13959: [SPARK-14351] [MLlib] [ML] Optimize findBestSplits metho...

2017-05-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/13959 @MechCoder, I apologize that, probably, it sounds the reason for my suggestion was not clear initially and if it looks without a respect. --- If your project is set up for it, you can reply to

[GitHub] spark issue #13959: [SPARK-14351] [MLlib] [ML] Optimize findBestSplits metho...

2017-05-18 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/13959 Yes, this is a tough issue. Let's wait and see if @jkbradley has thoughts on this issue. If we don't hear anything, then I'd leave it up to @MechCoder on whether to reopen. Thanks, btw, for taking th

[GitHub] spark issue #13959: [SPARK-14351] [MLlib] [ML] Optimize findBestSplits metho...

2017-05-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/13959 > The reason for closing PRs but _not_ their corresponding JIRA would be that the PR is either poorly implemented or the author is non-responsive. Yes, I tried to identify this case.

[GitHub] spark issue #13959: [SPARK-14351] [MLlib] [ML] Optimize findBestSplits metho...

2017-05-18 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/13959 This is fine, but are we not also policing JIRAs? I've argued above that the reason this PR has been inactive is simply lack of interest in this issue. If that's the case, then the JIRA must also be

[GitHub] spark issue #13959: [SPARK-14351] [MLlib] [ML] Optimize findBestSplits metho...

2017-05-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/13959 FWIW, I think we already had few discussion about the last resort - automatic-closing. I was strongly against this. This is my effort to prevent this for now ... --- If your project is set up

[GitHub] spark issue #13959: [SPARK-14351] [MLlib] [ML] Optimize findBestSplits metho...

2017-05-18 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/13959 True, and I'd probably close the JIRA too. Maybe we can draw @jkbradley 's attention for a comment? A closed PR still exists and can be examined or reopened, so it doesn't go away. I'd prefe

[GitHub] spark issue #13959: [SPARK-14351] [MLlib] [ML] Optimize findBestSplits metho...

2017-05-18 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/13959 The lack of bandwidth in MLlib means that sometimes good code that would make an impact just gets ignored. This is kind of the reality of things. However, if we are going to close the PR simply becau

[GitHub] spark issue #13959: [SPARK-14351] [MLlib] [ML] Optimize findBestSplits metho...

2017-05-18 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/13959 I think the problem is that this PR was incomplete, and left open. We generally only leave open PRs that are active. There was evidently no interest in proceeding with it; I don't know if it was lack

[GitHub] spark issue #13959: [SPARK-14351] [MLlib] [ML] Optimize findBestSplits metho...

2017-05-18 Thread MechCoder
Github user MechCoder commented on the issue: https://github.com/apache/spark/pull/13959 I don't understand. If you don't have time to review that is fine (I've been there too), but there is no need to close a PR due to unavailability of comitters. One of the reasons, that I

[GitHub] spark issue #13959: [SPARK-14351] [MLlib] [ML] Optimize findBestSplits metho...

2017-05-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/13959 I think we should fix the compatibility issue first rather then leaving this PR incomplete. If it is inactive, I would rather like to propose to close this for now. --- If your project is set

[GitHub] spark issue #13959: [SPARK-14351] [MLlib] [ML] Optimize findBestSplits metho...

2016-06-29 Thread MechCoder
Github user MechCoder commented on the issue: https://github.com/apache/spark/pull/13959 The test failure is just due to binary incompatibility. I can fix those once we decide that the current PR is the way to proceed. --- If your project is set up for it, you can reply to this email

[GitHub] spark issue #13959: [SPARK-14351] [MLlib] [ML] Optimize findBestSplits metho...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13959 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13959: [SPARK-14351] [MLlib] [ML] Optimize findBestSplits metho...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13959 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61427/ Test FAILed. ---

[GitHub] spark issue #13959: [SPARK-14351] [MLlib] [ML] Optimize findBestSplits metho...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13959 **[Test build #61427 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61427/consoleFull)** for PR 13959 at commit [`af1ff66`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13959: [SPARK-14351] [MLlib] [ML] Optimize findBestSplits metho...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13959 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61425/ Test FAILed. ---

[GitHub] spark issue #13959: [SPARK-14351] [MLlib] [ML] Optimize findBestSplits metho...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13959 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13959: [SPARK-14351] [MLlib] [ML] Optimize findBestSplits metho...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13959 **[Test build #61425 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61425/consoleFull)** for PR 13959 at commit [`e8b8914`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13959: [SPARK-14351] [MLlib] [ML] Optimize findBestSplits metho...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13959 **[Test build #61427 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61427/consoleFull)** for PR 13959 at commit [`af1ff66`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #13959: [SPARK-14351] [MLlib] [ML] Optimize findBestSplits metho...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13959 **[Test build #61425 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61425/consoleFull)** for PR 13959 at commit [`e8b8914`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #13959: [SPARK-14351] [MLlib] [ML] Optimize findBestSplits metho...

2016-06-28 Thread MechCoder
Github user MechCoder commented on the issue: https://github.com/apache/spark/pull/13959 @jkbradley @sethah Please have a look when free! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this