Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14555
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14555
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14555
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64059/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14555
**[Test build #64059 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64059/consoleFull)**
for PR 14555 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14555
**[Test build #64059 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64059/consoleFull)**
for PR 14555 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14555
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user adamzjw commented on the issue:
https://github.com/apache/spark/pull/14555
Hey, all. One of my colleagues run into a bug related to the discussion
above.
He called the Vectors.sparse(size: Int, indices: Array[Int], values:
Array[Double]) without noticing that
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14555
Last call for @mengxr or @jkbradley -- just want to make sure one's OK.
Certainly good for correctness.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14555
That's a good point, it's public now. I think I agree with you then, it's
fairly important to retain the validation there. It would also be inconsistent
to move it back, yes, because I see the other
Github user zjffdu commented on the issue:
https://github.com/apache/spark/pull/14555
@srowen Do you mean putting the validation back to method Vectors.sparse()
? The constructor of SparseVector is public, so I think we should keep the
validation in SparseVector rather than its
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14555
Ping @zjffdu
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14555
I think this is about ready, though to be conservative, I think we need to
put the validation back where it was, so that the more expensive check only
happens in Vectors.sparse and not the
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14555
OK, one last over-arching comment. I know the arg validation logic was
split over two methods, and I think it was on purpose, so that calls to the
`SparseVector` constructor didn't pay the full
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14555
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63603/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14555
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14555
**[Test build #63603 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63603/consoleFull)**
for PR 14555 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14555
**[Test build #63603 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63603/consoleFull)**
for PR 14555 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14555
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63530/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14555
**[Test build #63530 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63530/consoleFull)**
for PR 14555 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14555
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14555
**[Test build #63530 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63530/consoleFull)**
for PR 14555 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14555
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63518/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14555
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14555
**[Test build #63518 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63518/consoleFull)**
for PR 14555 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14555
**[Test build #63518 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63518/consoleFull)**
for PR 14555 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14555
**[Test build #63511 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63511/consoleFull)**
for PR 14555 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14555
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63511/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14555
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14555
**[Test build #63511 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63511/consoleFull)**
for PR 14555 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14555
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14555
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63416/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14555
**[Test build #63416 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63416/consoleFull)**
for PR 14555 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14555
**[Test build #63416 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63416/consoleFull)**
for PR 14555 at commit
33 matches
Mail list logo
