Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/17296
LGTM, merged to master. Thanks for creating the follow up JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/17296
@MLnick this should be good to go. I made
https://issues.apache.org/jira/browse/SPARK-20234 to address some better
consistency in these basic checks.
---
If your project is set up for it, you
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17296
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17296
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75551/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17296
**[Test build #75551 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75551/testReport)**
for PR 17296 at commit
[`7c7ce13`](https://github.com/apache/spark/commit/7
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17296
**[Test build #75551 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75551/testReport)**
for PR 17296 at commit
[`7c7ce13`](https://github.com/apache/spark/commit/7c
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/17296
High-level seems good now, though there are new conflicts in
`FPGrowthSuite` that need to be resolved.
Did you create a JIRA to track the broader issue of trying to make the
testing more gen
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17296
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75488/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17296
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17296
**[Test build #75488 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75488/testReport)**
for PR 17296 at commit
[`dd1e3bd`](https://github.com/apache/spark/commit/d
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/17296
cc @MLnick @jkbradley , I updated with the latest and added a check for the
model uid to match parent. I don't think it's great that this check is tacked
on to various other tests because it ma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17296
**[Test build #75488 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75488/testReport)**
for PR 17296 at commit
[`dd1e3bd`](https://github.com/apache/spark/commit/dd
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/17296
@MLnick , I found an existing `MLTestingUtils.checkCopy` that is used to
check the copied model uids match and can easily be extended to include the
check needed here. I went through and added
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/17296
hmm I would prefer to test it though I do get it's pretty tricky to do
generically. I don't think training a tiny model on a couple data points will
add too much overhead.
---
If your project is se
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/17296
Thanks @MLnick! I checked and didn't see this happening anywhere else.
It's not great to put into a test case because it requires training to get the
model. It could be tacked onto existing t
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/17296
Seems fine - are there other instances of this happening?
I'm wondering why test cases did not pick this up... seems like we should
have a standard test case for it?
---
If your project is
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/17296
ping @jkbradley @MLnick
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wis
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17296
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74557/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17296
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17296
**[Test build #74557 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74557/testReport)**
for PR 17296 at commit
[`a801ef9`](https://github.com/apache/spark/commit/a
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17296
**[Test build #74557 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74557/testReport)**
for PR 17296 at commit
[`a801ef9`](https://github.com/apache/spark/commit/a8
21 matches
Mail list logo
