[GitHub] spark issue #18308: [SPARK-21099][Spark Core] INFO Log Message Using Incorre...

2017-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18308 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark issue #18308: [SPARK-21099][Spark Core] INFO Log Message Using Incorre...

2017-06-14 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/18308 LGTM. BTW can you please complement the PR description, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #18308: [SPARK-21099][Spark Core] INFO Log Message Using Incorre...

2017-06-14 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18308 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #18308: [SPARK-21099][Spark Core] INFO Log Message Using Incorre...

2017-06-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18308 **[Test build #78086 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78086/testReport)** for PR 18308 at commit [`00a42e7`](https://github.com/apache/spark/commit/00

[GitHub] spark issue #18308: [SPARK-21099][Spark Core] INFO Log Message Using Incorre...

2017-06-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18308 **[Test build #78086 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78086/testReport)** for PR 18308 at commit [`00a42e7`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #18308: [SPARK-21099][Spark Core] INFO Log Message Using Incorre...

2017-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18308 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18308: [SPARK-21099][Spark Core] INFO Log Message Using Incorre...

2017-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18308 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78086/ Test FAILed. ---

[GitHub] spark issue #18308: [SPARK-21099][Spark Core] INFO Log Message Using Incorre...

2017-06-15 Thread ihazem
Github user ihazem commented on the issue: https://github.com/apache/spark/pull/18308 @jerryshao - I pushed another commit fixing removedExecutorId and removing ';'...thx for feedback on that. Regarding the edge case where the block manager was already removed and could pote

[GitHub] spark issue #18308: [SPARK-21099][Spark Core] INFO Log Message Using Incorre...

2017-06-15 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/18308 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #18308: [SPARK-21099][Spark Core] INFO Log Message Using Incorre...

2017-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18308 **[Test build #78126 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78126/testReport)** for PR 18308 at commit [`0f1c467`](https://github.com/apache/spark/commit/0f

[GitHub] spark issue #18308: [SPARK-21099][Spark Core] INFO Log Message Using Incorre...

2017-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18308 **[Test build #78126 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78126/testReport)** for PR 18308 at commit [`0f1c467`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #18308: [SPARK-21099][Spark Core] INFO Log Message Using Incorre...

2017-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18308 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18308: [SPARK-21099][Spark Core] INFO Log Message Using Incorre...

2017-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18308 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78126/ Test FAILed. ---

[GitHub] spark issue #18308: [SPARK-21099][Spark Core] INFO Log Message Using Incorre...

2017-06-15 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/18308 > I wonder if whether executor is completely gone or whether executor is still there but has no cached RDD, if both scenarios return false. Yes, that's the case, we cannot differentiate t

[GitHub] spark issue #18308: [SPARK-21099][Spark Core] INFO Log Message Using Incorre...

2017-06-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18308 **[Test build #3799 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3799/testReport)** for PR 18308 at commit [`0f1c467`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #18308: [SPARK-21099][Spark Core] INFO Log Message Using Incorre...

2017-06-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18308 **[Test build #3799 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3799/testReport)** for PR 18308 at commit [`0f1c467`](https://github.com/apache/spark/commit/

[GitHub] spark issue #18308: [SPARK-21099][Spark Core] INFO Log Message Using Incorre...

2017-06-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18308 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark issue #18308: [SPARK-21099][Spark Core] INFO Log Message Using Incorre...

2017-06-27 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18308 Ping @ihazem --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if t

[GitHub] spark issue #18308: [SPARK-21099][Spark Core] INFO Log Message Using Incorre...

2017-06-30 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18308 Ping @ihazem to update or close --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18308: [SPARK-21099][Spark Core] INFO Log Message Using Incorre...

2017-07-02 Thread ihazem
Github user ihazem commented on the issue: https://github.com/apache/spark/pull/18308 @srowen - I modified to take @vanzin recommendation of putting the logic in the logInfo call instead. I'm open to hearing any recommendations on using a less expensive call. Thx! --- If your projec

[GitHub] spark issue #18308: [SPARK-21099][Spark Core] INFO Log Message Using Incorre...

2017-07-02 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/18308 Can you update the title to: ``` [SPARK-21099][Core] Log cachedExecutorIdleTimeoutS instead of executorIdleTimeoutS if the executor has cached blocks ``` ? --- If your project

[GitHub] spark issue #18308: [SPARK-21099][Spark Core] INFO Log Message Using Incorre...

2017-07-03 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/18308 Is this the final modified code @ihazem , why do you check `hasCachedBlocks` both inside and outside of logInfo statement? Also the code is too long. Can you please at least do a round of

[GitHub] spark issue #18308: [SPARK-21099][Spark Core] INFO Log Message Using Incorre...

2017-07-06 Thread ihazem
Github user ihazem commented on the issue: https://github.com/apache/spark/pull/18308 @jerryshao - sorry about that...let me remove the logic outside the logInfo statements. Missed that. I'll do some more self-review and peer-review going fwd before submitting to not waste everyone's

[GitHub] spark issue #18308: [SPARK-21099][Spark Core] INFO Log Message Using Incorre...

2017-07-07 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/18308 There is no cheaper call you can make. Which is the problem here. So either you have to modify the code so that it keeps track of why the executor has timed out (i.e. more state being passed around),