[GitHub] spark issue #21554: [SPARK-24546][SQL] InsertIntoDataSourceCommand make data...

2018-06-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21554 by-position or by-name should be decided by end-users, not data sources. Unfortunately I don't know if there is a by-name insert syntax in SQL, but for `DataFrameWriter`, you can try

[GitHub] spark issue #21554: [SPARK-24546][SQL] InsertIntoDataSourceCommand make data...

2018-06-15 Thread zheh12
Github user zheh12 commented on the issue: https://github.com/apache/spark/pull/21554 I know this sql standard. But I wonder If I use `query.schema`, how it will affect the logic of by-position. I think we should let datasource implement has the ability to decide use

[GitHub] spark issue #21554: [SPARK-24546][SQL] InsertIntoDataSourceCommand make data...

2018-06-13 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21554 This follows the SQL standard, isn't it? INSERT INTO uses by-position match, not by-name. --- - To unsubscribe, e-mail:

[GitHub] spark issue #21554: [SPARK-24546][SQL] InsertIntoDataSourceCommand make data...

2018-06-13 Thread zheh12
Github user zheh12 commented on the issue: https://github.com/apache/spark/pull/21554 cc @cloud-fan @jiangxb1987, please give me some advise. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #21554: [SPARK-24546][SQL] InsertIntoDataSourceCommand make data...

2018-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21554 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21554: [SPARK-24546][SQL] InsertIntoDataSourceCommand make data...

2018-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21554 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21554: [SPARK-24546][SQL] InsertIntoDataSourceCommand make data...

2018-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21554 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional