Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22513
+1, late LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22513
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22513
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96415/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22513
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22513
**[Test build #96415 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96415/testReport)**
for PR 22513 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22513
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22513
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96407/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22513
**[Test build #96407 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96407/testReport)**
for PR 22513 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22513
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22513
@cloud-fan @wangyum Thanks for the suggestion. I have updated the target
package and related PR description.
---
-
To
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22513
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22513
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22513
**[Test build #96415 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96415/testReport)**
for PR 22513 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22513
Please also explain which module(core or sql?) these benchmark classes
should be, in the PR description.
---
-
To
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22513
**[Test build #96407 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96407/testReport)**
for PR 22513 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22513
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22513
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22513
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22513
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22513
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96397/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22513
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96403/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22513
**[Test build #96403 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96403/testReport)**
for PR 22513 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22513
**[Test build #96397 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96397/testReport)**
for PR 22513 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22513
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22513
**[Test build #96403 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96403/testReport)**
for PR 22513 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22513
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22513
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22513
> KryoBenchmark is in core, and UnsafeProjectionBenchmark,
HashByteArrayBenchmark and HashBenchmark are in catalyst. If we move the
benchmark base class to sql, benchmarks mentioned above
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22513
`KryoBenchmark` is in core, and `UnsafeProjectionBenchmark`,
`HashByteArrayBenchmark` and `HashBenchmark` are in `catalyst`. If we move the
benchmark base class to sql, benchmarks mentioned above
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22513
**[Test build #96397 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96397/testReport)**
for PR 22513 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22513
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22513
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22513
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96396/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22513
**[Test build #96396 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96396/testReport)**
for PR 22513 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22513
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22513
**[Test build #96396 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96396/testReport)**
for PR 22513 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22513
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22513
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22513
@wangyum @yucai @dongjoon-hyun @cloud-fan @gatorsmile
Let's focus on this before we merge other benchmark PRs.
---
-
39 matches
Mail list logo
