[GitHub] spark pull request: [EC2] Cleanup Python parens and disk dict

2014-09-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2571 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [EC2] Cleanup Python parens and disk dict

2014-09-28 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/2571#issuecomment-57116856 Merging in master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [EC2] Cleanup Python parens and disk dict

2014-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2571#issuecomment-57116842 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20

[GitHub] spark pull request: [EC2] Cleanup Python parens and disk dict

2014-09-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2571#issuecomment-57116839 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20957/consoleFull) for PR 2571 at commit [`9d203d5`](https://github.com/a

[GitHub] spark pull request: [EC2] Cleanup Python parens and disk dict

2014-09-28 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/2571#issuecomment-57114495 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request: [EC2] Cleanup Python parens and disk dict

2014-09-28 Thread nchammas
Github user nchammas commented on the pull request: https://github.com/apache/spark/pull/2571#issuecomment-57114433 cc @rxin @pwendell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [EC2] Cleanup Python parens and disk dict

2014-09-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2571#issuecomment-57114126 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20957/consoleFull) for PR 2571 at commit [`9d203d5`](https://github.com/ap

[GitHub] spark pull request: [EC2] Cleanup Python parens and disk dict

2014-09-28 Thread nchammas
Github user nchammas commented on a diff in the pull request: https://github.com/apache/spark/pull/2571#discussion_r18136353 --- Diff: ec2/spark_ec2.py --- @@ -820,18 +820,18 @@ def ssh_read(host, opts, command): ssh_command(opts) + ['%s@%s' % (opts.user, host), string

[GitHub] spark pull request: [EC2] Cleanup Python parens and disk dict

2014-09-28 Thread nchammas
Github user nchammas commented on a diff in the pull request: https://github.com/apache/spark/pull/2571#discussion_r18136340 --- Diff: ec2/spark_ec2.py --- @@ -626,43 +626,43 @@ def wait_for_cluster(conn, wait_secs, master_nodes, slave_nodes): def get_num_disks(instance_type):

[GitHub] spark pull request: [EC2] Cleanup Python parens and disk dict

2014-09-28 Thread nchammas
Github user nchammas commented on a diff in the pull request: https://github.com/apache/spark/pull/2571#discussion_r18136317 --- Diff: ec2/spark_ec2.py --- @@ -508,7 +508,7 @@ def tag_instance(instance, name): break except: print "Faile

[GitHub] spark pull request: [EC2] Cleanup Python parens and disk dict

2014-09-28 Thread nchammas
GitHub user nchammas opened a pull request: https://github.com/apache/spark/pull/2571 [EC2] Cleanup Python parens and disk dict Minor fixes: * Remove unnecessary parens (Python style) * Sort `disks_by_instance` dict and remove duplicate `t1.micro` key You can merge this pull