Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/12773#discussion_r61547437
--- Diff: core/src/main/scala/org/apache/spark/NewAccumulator.scala ---
@@ -197,7 +199,7 @@ private[spark] object AccumulatorContext {
* TODO: Don't use
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12773#issuecomment-215628448
**[Test build #2926 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2926/consoleFull)**
for PR 12773 at commit
[`ea2ba20`](https://
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12773#issuecomment-215627564
**[Test build #2928 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2928/consoleFull)**
for PR 12773 at commit
[`ea2ba20`](https://
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12773#issuecomment-215627327
**[Test build #2927 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2927/consoleFull)**
for PR 12773 at commit
[`ea2ba20`](https://
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12773
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12773#issuecomment-215626966
I'm going to merge this. Let's see how the tests pan out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12773#issuecomment-215627013
**[Test build #2925 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2925/consoleFull)**
for PR 12773 at commit
[`ea2ba20`](https://
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12773#issuecomment-215626991
**[Test build #2929 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2929/consoleFull)**
for PR 12773 at commit
[`ea2ba20`](https://
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12773#issuecomment-215626610
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12773#issuecomment-215626609
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12773#issuecomment-215626453
**[Test build #57300 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57300/consoleFull)**
for PR 12773 at commit
[`ea2ba20`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12773#issuecomment-215622662
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12773#issuecomment-215622661
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12773#issuecomment-215622600
**[Test build #57299 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57299/consoleFull)**
for PR 12773 at commit
[`ea2ba20`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12773#issuecomment-215616890
**[Test build #2928 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2928/consoleFull)**
for PR 12773 at commit
[`ea2ba20`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12773#issuecomment-215616903
**[Test build #2929 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2929/consoleFull)**
for PR 12773 at commit
[`ea2ba20`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12773#issuecomment-215616837
**[Test build #2925 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2925/consoleFull)**
for PR 12773 at commit
[`ea2ba20`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12773#issuecomment-215616866
**[Test build #2927 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2927/consoleFull)**
for PR 12773 at commit
[`ea2ba20`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12773#issuecomment-215616838
**[Test build #57300 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57300/consoleFull)**
for PR 12773 at commit
[`ea2ba20`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12773#issuecomment-215616855
**[Test build #2926 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2926/consoleFull)**
for PR 12773 at commit
[`ea2ba20`](https://g
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12773#issuecomment-215616619
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12773#issuecomment-215614070
**[Test build #57299 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57299/consoleFull)**
for PR 12773 at commit
[`ea2ba20`](https://gi
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/12773#issuecomment-215613977
cc @rxin @davies @yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/12773
[HOTFIX][CORE] fix a concurrence issue in NewAccumulator
## What changes were proposed in this pull request?
`AccumulatorContext` is not thread-safe, that's why all of its methods are
sy
24 matches
Mail list logo
