Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3626#issuecomment-55956
I think the original Map was OK, IMHO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user acidghost commented on the pull request:
https://github.com/apache/spark/pull/3626#issuecomment-60588
@srowen I just created PR #6761
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user acidghost commented on the pull request:
https://github.com/apache/spark/pull/3626#issuecomment-31476
@jkbradley @srowen Do you think that the return type of
`predictProbabilities` should be `scala.collection.Map[Double, Double]` or
`Vector[Double]`?
---
If your
Github user acidghost commented on the pull request:
https://github.com/apache/spark/pull/3626#issuecomment-110630408
Hello there! I'm interested in reopening this PR and contributing with a
patch to [SPARK-4362] based on this PR with the needed changes. I read [the
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3626
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3626#issuecomment-78520891
Mind closing this PR? if it's not going to be updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3626#issuecomment-75564514
@alanctgardner have you had a look at @jkbradley 's feedback? I'm wondering
this is still live. It needs a rebase if so.
---
If your project is set up for it, you can
Github user alanctgardner commented on a diff in the pull request:
https://github.com/apache/spark/pull/3626#discussion_r25172516
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -65,6 +66,25 @@ class NaiveBayesModel private[mllib] (
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/3626#issuecomment-75608187
@alanctgardner That will be great if you change it to
predictProbabilities; thanks. I agree with what @jatinpreet was saying about
the correctness, and with @srowen
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3626#discussion_r21563627
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -65,6 +66,25 @@ class NaiveBayesModel private[mllib] (
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3626#discussion_r21563623
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -65,6 +66,25 @@ class NaiveBayesModel private[mllib] (
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3626#discussion_r21564191
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -65,6 +66,25 @@ class NaiveBayesModel private[mllib] (
GitHub user alanctgardner opened a pull request:
https://github.com/apache/spark/pull/3626
[MLLIB] SPARK-4362: Added classProbabilities method for Naive Bayes
Added methods which accept an RDD or array and return a map of (label -
posterior prob.) for each input set rather than
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3626#discussion_r21402613
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -65,6 +65,24 @@ class NaiveBayesModel private[mllib] (
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3626#issuecomment-65859729
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3626#discussion_r21402733
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -65,6 +65,24 @@ class NaiveBayesModel private[mllib] (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3626#discussion_r21402810
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -65,6 +65,24 @@ class NaiveBayesModel private[mllib] (
Github user alanctgardner commented on a diff in the pull request:
https://github.com/apache/spark/pull/3626#discussion_r21402907
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -65,6 +65,24 @@ class NaiveBayesModel private[mllib] (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3626#discussion_r21403159
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -65,6 +65,24 @@ class NaiveBayesModel private[mllib] (
19 matches
Mail list logo
