Github user Jiechor commented on the pull request:
https://github.com/apache/spark/pull/1719#issuecomment-124967482
"The RDDâstorage in the algorithm default persist in memory?@mengxr
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user vivounicorn commented on the pull request:
https://github.com/apache/spark/pull/1719#issuecomment-55355088
we have an initial implementation using downpour SGD,our goal is support
ten million words/usersï¼it 's really hard.
---
If your project is set up for it, you can
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1719#issuecomment-51025157
QA results for PR 1719:- This patch PASSES unit tests.- This patch
merges cleanly- This patch adds the following public classes
(experimental):class Word2Vec(For more inf
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1719
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/1719#issuecomment-51023600
LGTM. Merged into both master and branch-1.1. @Ishiihara Thanks a lot for
implementing word2vec! Please help improve its performance during the QA
period. One task left is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1719#issuecomment-51023016
QA results for PR 1719:- This patch PASSES unit tests.- This patch
merges cleanly- This patch adds the following public classes
(experimental):class Word2Vec(For more inf
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1719#issuecomment-51021526
QA tests have started for PR 1719. This patch merges cleanly. View
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17846/consoleFull
---
If
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/1719#issuecomment-51021254
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1719#issuecomment-51020440
QA results for PR 1719:- This patch FAILED unit tests.- This patch
merges cleanly- This patch adds the following public classes
(experimental):class Word2Vec(For more inf
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1719#issuecomment-51019953
QA tests have started for PR 1719. This patch merges cleanly. View
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17843/consoleFull
---
If
Github user Ishiihara commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15741135
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/feature/Word2VecSuite.scala ---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Found
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15740911
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/feature/Word2VecSuite.scala ---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1719#issuecomment-51018495
QA tests have started for PR 1719. This patch merges cleanly. View
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17842/consoleFull
---
If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1719#issuecomment-51017655
QA results for PR 1719:- This patch PASSES unit tests.- This patch
merges cleanly- This patch adds the following public classes
(experimental):class Word2Vec(For more inf
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1719#issuecomment-51015705
QA tests have started for PR 1719. This patch merges cleanly. View
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17840/consoleFull
---
If
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15739777
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,426 @@
+/*
+ * Licensed to the Apache Software Foundation (
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1719#issuecomment-51008212
QA results for PR 1719:- This patch PASSES unit tests.- This patch
merges cleanly- This patch adds the following public classes
(experimental):class Word2Vec(For more inf
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1719#issuecomment-51006777
QA tests have started for PR 1719. This patch merges cleanly. View
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17830/consoleFull
---
If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1719#issuecomment-51001654
QA results for PR 1719:- This patch PASSES unit tests.- This patch
merges cleanly- This patch adds the following public classes
(experimental):class Word2Vec(For more inf
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1719#issuecomment-51000166
QA results for PR 1719:- This patch PASSES unit tests.- This patch
merges cleanly- This patch adds the following public classes
(experimental):class Word2Vec(For more inf
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1719#issuecomment-5084
QA tests have started for PR 1719. This patch merges cleanly. View
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17823/consoleFull
---
If
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15735833
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,414 @@
+/*
+ * Licensed to the Apache Software Foundation (
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15735830
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,414 @@
+/*
+ * Licensed to the Apache Software Foundation (
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15735820
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,414 @@
+/*
+ * Licensed to the Apache Software Foundation (
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15735823
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,414 @@
+/*
+ * Licensed to the Apache Software Foundation (
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15735818
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,414 @@
+/*
+ * Licensed to the Apache Software Foundation (
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15735816
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,414 @@
+/*
+ * Licensed to the Apache Software Foundation (
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1719#issuecomment-50998279
QA tests have started for PR 1719. This patch merges cleanly. View
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17820/consoleFull
---
If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1719#issuecomment-50956096
QA results for PR 1719:- This patch PASSES unit tests.- This patch
merges cleanly- This patch adds the following public classes
(experimental):class Word2Vec(For more inf
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1719#issuecomment-50955037
QA tests have started for PR 1719. This patch merges cleanly. View
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17756/consoleFull
---
If
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15727134
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,401 @@
+/*
+ * Licensed to the Apache Software Foundation (
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15727095
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,401 @@
+/*
+ * Licensed to the Apache Software Foundation (
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15727075
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,401 @@
+/*
+ * Licensed to the Apache Software Foundation (
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1719#issuecomment-50951455
QA results for PR 1719:- This patch PASSES unit tests.- This patch
merges cleanly- This patch adds the following public classes
(experimental):class Word2Vec(For more inf
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1719#issuecomment-50950095
QA tests have started for PR 1719. This patch merges cleanly. View
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17728/consoleFull
---
If
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/1719#issuecomment-50949973
How about making more iterations?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user Ishiihara commented on the pull request:
https://github.com/apache/spark/pull/1719#issuecomment-50949833
@mengxr result of 4 and 10 partitions make sense but result of 100
partitions doesn't make sense.
Made changes according to review except the random seed. Will con
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15724703
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,375 @@
+/*
+* Licensed to the Apache Software Foundation (A
Github user Ishiihara commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15723320
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,375 @@
+/*
+* Licensed to the Apache Software Foundation
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/1719#issuecomment-50941289
@Ishiihara Did you try using more than one partitions? How is the accuracy?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15721977
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,375 @@
+/*
+* Licensed to the Apache Software Foundation (A
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15721930
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,375 @@
+/*
+* Licensed to the Apache Software Foundation (A
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15721918
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,375 @@
+/*
+* Licensed to the Apache Software Foundation (A
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15721908
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/feature/Word2VecSuite.scala ---
@@ -0,0 +1,40 @@
+/*
+* Licensed to the Apache Software Foundatio
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15721868
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,375 @@
+/*
+* Licensed to the Apache Software Foundation (A
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15721821
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,375 @@
+/*
+* Licensed to the Apache Software Foundation (A
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15721791
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,375 @@
+/*
+* Licensed to the Apache Software Foundation (A
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15721802
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,375 @@
+/*
+* Licensed to the Apache Software Foundation (A
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15721765
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,375 @@
+/*
+* Licensed to the Apache Software Foundation (A
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15721747
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,375 @@
+/*
+* Licensed to the Apache Software Foundation (A
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15721768
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,375 @@
+/*
+* Licensed to the Apache Software Foundation (A
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15721704
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,375 @@
+/*
+* Licensed to the Apache Software Foundation (A
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15721563
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,375 @@
+/*
+* Licensed to the Apache Software Foundation (A
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15721454
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,375 @@
+/*
+* Licensed to the Apache Software Foundation (A
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15721390
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,375 @@
+/*
+* Licensed to the Apache Software Foundation (A
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15721254
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,375 @@
+/*
+* Licensed to the Apache Software Foundation (A
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15721232
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,375 @@
+/*
+* Licensed to the Apache Software Foundation (A
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15721184
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,375 @@
+/*
+* Licensed to the Apache Software Foundation (A
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15721159
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,375 @@
+/*
+* Licensed to the Apache Software Foundation (A
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15721094
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,375 @@
+/*
+* Licensed to the Apache Software Foundation (A
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15720956
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,375 @@
+/*
+* Licensed to the Apache Software Foundation (A
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15720822
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,375 @@
+/*
+* Licensed to the Apache Software Foundation (A
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15720780
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,375 @@
+/*
+* Licensed to the Apache Software Foundation (A
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1719#discussion_r15720792
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -0,0 +1,375 @@
+/*
+* Licensed to the Apache Software Foundation (A
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1719#issuecomment-50904679
QA results for PR 1719:- This patch FAILED unit tests.- This patch
merges cleanly- This patch adds the following public classes
(experimental):class Word2Vec(class Word2V
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1719#issuecomment-50904577
QA tests have started for PR 1719. This patch merges cleanly. View
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17680/consoleFull
---
If
Github user Ishiihara commented on the pull request:
https://github.com/apache/spark/pull/1719#issuecomment-50904281
@mengxr code format done. Working on test case of algorithm.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
67 matches
Mail list logo
