Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8458
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-139352179
Thanks @sun-rui -- LGTM. Merging this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-139346373
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-139346369
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-139346063
[Test build #42272 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42272/console)
for PR 8458 at commit
[`afad2c6`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-139295071
[Test build #42272 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42272/consoleFull)
for PR 8458 at commit
[`afad2c6`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-139292545
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-139292617
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-139290777
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-139199020
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-139199019
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-139198943
[Test build #42252 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42252/console)
for PR 8458 at commit
[`afad2c6`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-139153620
[Test build #42252 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42252/consoleFull)
for PR 8458 at commit
[`afad2c6`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-139151105
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-139151127
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/8458#discussion_r39133491
--- Diff: core/src/main/scala/org/apache/spark/api/r/RBackendHandler.scala
---
@@ -166,40 +178,75 @@ private[r] class RBackendHandler(server: RBackend)
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8458#discussion_r39125826
--- Diff: core/src/main/scala/org/apache/spark/api/r/RBackendHandler.scala
---
@@ -166,40 +178,75 @@ private[r] class RBackendHandler(server: RBackend)
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-139114356
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-139114357
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-139114308
[Test build #42228 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42228/console)
for PR 8458 at commit
[`a7aa017`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-139092772
[Test build #42228 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42228/consoleFull)
for PR 8458 at commit
[`a7aa017`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-139092041
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-139092029
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/8458#discussion_r39117310
--- Diff: core/src/main/scala/org/apache/spark/api/r/RBackendHandler.scala
---
@@ -166,40 +178,75 @@ private[r] class RBackendHandler(server: RBackend)
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/8458#discussion_r39115489
--- Diff: core/src/main/scala/org/apache/spark/api/r/RBackendHandler.scala
---
@@ -166,40 +178,75 @@ private[r] class RBackendHandler(server: RBackend)
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-138988675
@sun-rui The changes looks good to me overall, just two minor comments,
thanks!
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8458#discussion_r39071332
--- Diff: core/src/main/scala/org/apache/spark/api/r/RBackendHandler.scala
---
@@ -166,40 +178,75 @@ private[r] class RBackendHandler(server: RBackend)
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8458#discussion_r39070837
--- Diff: core/src/main/scala/org/apache/spark/api/r/RBackendHandler.scala
---
@@ -166,40 +178,75 @@ private[r] class RBackendHandler(server: RBackend)
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-138957499
@shivaram @sun-rui I will review this today, sorry for the late.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-138815007
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-138815008
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-138814837
[Test build #42188 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42188/console)
for PR 8458 at commit
[`adde91f`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-138784377
[Test build #42188 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42188/consoleFull)
for PR 8458 at commit
[`adde91f`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-138780239
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-138780172
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/8458#discussion_r38995711
--- Diff: core/src/main/scala/org/apache/spark/api/r/RBackendHandler.scala
---
@@ -171,35 +183,58 @@ private[r] class RBackendHandler(server: RBackend)
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-138633096
@sun-rui Sorry for the delay - Code looks pretty good to me and I just one
minor inline comment.
@davies Would be great if you could also take a look
---
If y
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/8458#discussion_r38950081
--- Diff: core/src/main/scala/org/apache/spark/api/r/RBackendHandler.scala
---
@@ -171,35 +183,58 @@ private[r] class RBackendHandler(server: RBackend)
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-138040804
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-138040803
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-138040786
[Test build #42065 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42065/console)
for PR 8458 at commit
[`1e223e0`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-138032731
[Test build #42065 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42065/consoleFull)
for PR 8458 at commit
[`1e223e0`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-138032018
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-138032043
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-137895854
[Test build #42033 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42033/console)
for PR 8458 at commit
[`a1f4fcb`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-137895855
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-137895856
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-137895488
[Test build #42033 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42033/consoleFull)
for PR 8458 at commit
[`a1f4fcb`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-137895099
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-137895095
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/8458#discussion_r38601927
--- Diff: core/src/main/scala/org/apache/spark/api/r/RBackendHandler.scala
---
@@ -171,35 +183,53 @@ private[r] class RBackendHandler(server: RBackend)
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/8458#discussion_r38601919
--- Diff: R/pkg/R/SQLContext.R ---
@@ -49,7 +49,7 @@ infer_type <- function(x) {
stopifnot(length(x) > 0)
names <- names(x)
if (is.n
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/8458#discussion_r38574919
--- Diff: core/src/main/scala/org/apache/spark/api/r/RBackendHandler.scala
---
@@ -171,35 +183,53 @@ private[r] class RBackendHandler(server: RBackend)
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/8458#discussion_r38561913
--- Diff: R/pkg/R/SQLContext.R ---
@@ -49,7 +49,7 @@ infer_type <- function(x) {
stopifnot(length(x) > 0)
names <- names(x)
if (is.
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-135648633
@sun-rui I'll take a look at this tomorrow
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-135647453
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-135647454
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-135647373
[Test build #41723 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41723/console)
for PR 8458 at commit
[`2bc97ad`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-135623885
[Test build #41723 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41723/consoleFull)
for PR 8458 at commit
[`2bc97ad`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-135623380
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-135623371
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/8458#issuecomment-135601195
@davies , @shivaram , Could you help to review it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
62 matches
Mail list logo
