[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-16 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-157128630 Also merged to branch-1.5. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9272 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-15 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-156866902 Thanks! Merging to master and branch 1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-156784632 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-156784631 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-156784614 **[Test build #45944 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45944/consoleFull)** for PR 9272 at commit [`caf51a7`](https://git

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-14 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-156775010 LGTM pending jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-14 Thread yolandagao
Github user yolandagao commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-156774495 Thank you Yin for the review. Updated the comments accordingly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-156774463 **[Test build #45944 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45944/consoleFull)** for PR 9272 at commit [`caf51a7`](https://gith

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-156758037 **[Test build #45937 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45937/consoleFull)** for PR 9272 at commit [`1fbc372`](https://git

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-14 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9272#discussion_r44863760 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/ClientWrapper.scala --- @@ -20,6 +20,8 @@ package org.apache.spark.sql.hive.client impor

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-14 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-156746093 @yolandagao Thank you for the update. Overall looks good. Left two comments. --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-14 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9272#discussion_r44863646 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -521,8 +521,18 @@ object SparkSubmit { sysProps.put("spark.yarn.isPyt

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-14 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9272#discussion_r44863636 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/ClientWrapper.scala --- @@ -149,6 +151,26 @@ private[hive] class ClientWrapper( val

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-156745289 **[Test build #45937 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45937/consoleFull)** for PR 9272 at commit [`1fbc372`](https://gith

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-14 Thread yolandagao
Github user yolandagao commented on a diff in the pull request: https://github.com/apache/spark/pull/9272#discussion_r44863090 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/ClientWrapper.scala --- @@ -150,6 +152,21 @@ private[hive] class ClientWrapper(

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-13 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9272#discussion_r44814575 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/ClientWrapper.scala --- @@ -150,6 +152,21 @@ private[hive] class ClientWrapper( val

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-12 Thread yolandagao
Github user yolandagao commented on a diff in the pull request: https://github.com/apache/spark/pull/9272#discussion_r44742954 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/ClientWrapper.scala --- @@ -150,6 +152,21 @@ private[hive] class ClientWrapper(

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-09 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9272#discussion_r44344327 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/ClientWrapper.scala --- @@ -150,6 +152,21 @@ private[hive] class ClientWrapper( val

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-155219421 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-155219229 **[Test build #45392 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45392/consoleFull)** for PR 9272 at commit [`7d09f5d`](https://git

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-155155001 **[Test build #45392 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45392/consoleFull)** for PR 9272 at commit [`7d09f5d`](https://gith

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-155152432 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-155152397 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-09 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-155152136 @yolandagao you can try saying "jenkins retest this please" in a comment (I know if you've been whitelisted it will trigger a retest less certain if not yet whitelisted)

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-08 Thread yolandagao
Github user yolandagao commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-154941484 The org.apache.spark.sql.hive.thriftserver.CliSuite timeout failure seems not related to the change but some environment issue. Ran the test suite on my mac machine s

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-154876596 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-154876577 **[Test build #45308 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45308/consoleFull)** for PR 9272 at commit [`7d09f5d`](https://git

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-154859065 **[Test build #45308 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45308/consoleFull)** for PR 9272 at commit [`7d09f5d`](https://gith

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-154858798 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-154858809 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-06 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-154594150 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-05 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/9272#discussion_r44013419 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/ClientWrapper.scala --- @@ -150,6 +152,14 @@ private[hive] class ClientWrapper(

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-05 Thread yolandagao
Github user yolandagao commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-154014784 Updated and tested the change - in yarn client and cluster mode, with and without keytab/principal parameters. Please take a look. Thank you! --- If your project is

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-04 Thread yolandagao
Github user yolandagao commented on a diff in the pull request: https://github.com/apache/spark/pull/9272#discussion_r43974652 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/ClientWrapper.scala --- @@ -150,6 +152,14 @@ private[hive] class ClientWrapper(

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-04 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/9272#discussion_r43867986 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/ClientWrapper.scala --- @@ -150,6 +152,14 @@ private[hive] class ClientWrapper(

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-04 Thread steveloughran
Github user steveloughran commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-153688412 This is unrelated to the SPARK-11265 patch; that's all about getting reflection to find the right methods. This is about UGI setup. --- If your project is set up

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-04 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/9272#discussion_r43867512 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/ClientWrapper.scala --- @@ -150,6 +152,14 @@ private[hive] class ClientWrapper(

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-03 Thread yolandagao
Github user yolandagao commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-153287881 Hi folks, Yarn Client.scala checks the setting from argStrings (passed from SparkSubmit) and sparkConf (which loads java system properties starting with spark.*

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-03 Thread yolandagao
Github user yolandagao commented on a diff in the pull request: https://github.com/apache/spark/pull/9272#discussion_r43724262 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -520,6 +520,8 @@ object SparkSubmit { } if (args.princi

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-02 Thread yolandagao
Github user yolandagao commented on a diff in the pull request: https://github.com/apache/spark/pull/9272#discussion_r43717742 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -520,6 +520,8 @@ object SparkSubmit { } if (args.princi

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-02 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/9272#discussion_r43707087 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -520,6 +520,8 @@ object SparkSubmit { } if (args.principal

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-02 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/9272#discussion_r43705844 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -520,6 +520,8 @@ object SparkSubmit { } if (args.principal

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-01 Thread yolandagao
Github user yolandagao commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-152904592 @yhuai Hi Yin, SPARK-11265 is a different issue - in yarn Client.scala code, hive metastore token is obtained when kerberos is enabled to set up AM container launch c

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-01 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-152893639 @yolandagao Is https://github.com/apache/spark/commit/40d3c6797a3dfd037eb69b2bcd336d8544deddf5 for the same issue (for a similar issue)? @steveloughran Can you take a look

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-01 Thread yolandagao
Github user yolandagao commented on a diff in the pull request: https://github.com/apache/spark/pull/9272#discussion_r43592751 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -520,6 +520,8 @@ object SparkSubmit { } if (args.princi

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-10-26 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9272#discussion_r43040951 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -520,6 +520,8 @@ object SparkSubmit { } if (args.principal !

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-10-26 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-151257965 This this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-150965943 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-10-25 Thread yolandagao
GitHub user yolandagao opened a pull request: https://github.com/apache/spark/pull/9272 [SPARK-10181][SQL] Do kerberos login for credentials during hive client initialization On driver process start up, UserGroupInformation.loginUserFromKeytab is called with the principal and keyta