Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8395
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8395#issuecomment-135507172
(PS not sure why it doesn't seem to show up, but the tests passed again
after the last commit:
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8395#issuecomment-135364212
LGTM, I'm going to merge for 1.6 shortly
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8395#issuecomment-134227420
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8395#issuecomment-134242152
[Test build #1685 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1685/consoleFull)
for PR 8395 at commit
GitHub user SlavikBaranov opened a pull request:
https://github.com/apache/spark/pull/8395
[SPARK-10182] [MLlib] GeneralizedLinearModel doesn't unpersist cached data
`GeneralizedLinearModel` creates a cached RDD when building a model. It's
inconvenient, since these RDDs flood the
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8395#issuecomment-134241071
I get it, it's maybe because the one path is not cached. This looks good to
me. The only thing I wonder is this: clearly the code is expecting that the
input should be
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8395#issuecomment-134261044
[Test build #1685 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1685/console)
for PR 8395 at commit
Github user SlavikBaranov commented on the pull request:
https://github.com/apache/spark/pull/8395#issuecomment-134327407
@srowen I think, intermediate data is cached because it significantly
improves performance if the number of features is high (since `appendBias`
method performs
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8395#discussion_r37788602
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/GeneralizedLinearAlgorithm.scala
---
@@ -287,7 +282,7 @@ abstract class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8395#discussion_r37808640
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/GeneralizedLinearAlgorithm.scala
---
@@ -287,7 +282,7 @@ abstract class
11 matches
Mail list logo
