Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8399
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8399#issuecomment-135656766
No, this LGTM. I'll merge this with branch-1.5 and master now. Thanks
very much!
---
If your project is set up for it, you can reply to this email and have your
rep
Github user noel-smith commented on the pull request:
https://github.com/apache/spark/pull/8399#issuecomment-135655500
That would be great - I've just messaged him. If there are any other
changes you need to get this into 1.5 I'll get them in ASAP today.
---
If your project is set up
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8399#issuecomment-135605403
[Test build #1700 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1700/console)
for PR 8399 at commit
[`bada453`](https://github
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8399#issuecomment-135603184
[Test build #1700 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1700/consoleFull)
for PR 8399 at commit
[`bada453`](https://git
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8399#issuecomment-135603112
Ping @mengxr In case I can't check this soon, it would be great to get this
into 1.5 if there is an RC3.
---
If your project is set up for it, you can reply to this e
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8399#issuecomment-135576579
[Test build #1699 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1699/console)
for PR 8399 at commit
[`7794cf7`](https://github
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8399#issuecomment-135576535
[Test build #1699 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1699/consoleFull)
for PR 8399 at commit
[`7794cf7`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8399#issuecomment-135204427
[Test build #1695 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1695/console)
for PR 8399 at commit
[`7794cf7`](https://github
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8399#issuecomment-135204382
[Test build #1695 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1695/consoleFull)
for PR 8399 at commit
[`7794cf7`](https://git
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8399#issuecomment-135204119
Looks good except for those 2 items.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8399#discussion_r38047496
--- Diff: python/pyspark/ml/evaluation.py ---
@@ -85,6 +88,9 @@ def _evaluate(self, dataset):
self._transfer_params_to_java()
retur
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8399#discussion_r38047455
--- Diff: python/pyspark/ml/evaluation.py ---
@@ -66,6 +66,9 @@ def evaluate(self, dataset, params=None):
else:
raise ValueErro
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8399#issuecomment-135195804
Thanks for the PR! I'll take a look now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8399#issuecomment-135195777
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
GitHub user noel-smith opened a pull request:
https://github.com/apache/spark/pull/8399
[SPARK-10188] [Pyspark] Pyspark CrossValidator with RMSE selects incorrect
model
* Added isLargerBetter() method to Pyspark Evaluator to match the Scala
version.
* JavaEvaluator delegates is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8399#issuecomment-134344428
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
17 matches
Mail list logo
