Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8513
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8513#issuecomment-163319977
Merged to master/1.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/8513#issuecomment-163107088
@jkbradley addressed the issues (also cleaned up the rest of the tests in
the same file)
---
If your project is set up for it, you can reply to this email and have your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8513#issuecomment-163065219
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8513#issuecomment-163065217
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8513#issuecomment-163065129
**[Test build #47372 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47372/consoleFull)**
for PR 8513 at commit
[`76d7b5b`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8513#issuecomment-163057347
**[Test build #47372 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47372/consoleFull)**
for PR 8513 at commit
[`76d7b5b`](https://gith
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/8513#discussion_r47030372
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/Word2VecSuite.scala ---
@@ -131,7 +131,42 @@ class Word2VecSuite extends SparkFunSuite with
MLlibT
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/8513#discussion_r47030172
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/Word2VecSuite.scala ---
@@ -131,7 +131,42 @@ class Word2VecSuite extends SparkFunSuite with
MLlibT
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8513#issuecomment-162885645
**[Test build #2182 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2182/consoleFull)**
for PR 8513 at commit
[`c125c3b`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8513#issuecomment-162874704
**[Test build #2182 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2182/consoleFull)**
for PR 8513 at commit
[`c125c3b`](https://git
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8513#discussion_r46948787
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/Word2VecSuite.scala ---
@@ -131,7 +131,42 @@ class Word2VecSuite extends SparkFunSuite with
MLlibTest
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8513#issuecomment-162735588
Just had minor comments, but I feel like the SQLContext issue should
probably be fixed before merging. I'm OK with putting it in 1.6
---
If your project is set up fo
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8513#discussion_r46906806
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -49,6 +49,17 @@ private[feature] trait Word2VecBase extends Params
d
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8513#discussion_r46906813
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -49,6 +49,17 @@ private[feature] trait Word2VecBase extends Params
d
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8513#discussion_r46906844
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/Word2VecSuite.scala ---
@@ -131,7 +131,42 @@ class Word2VecSuite extends SparkFunSuite with
MLli
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8513#issuecomment-162613178
I'm OK with that; it's quite safe and minor. I'd understand if someone
objected since it's not a fix. Let me pause for that.
---
If your project is set up for it, you ca
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/8513#issuecomment-162612112
@srowen @marmbrus @rxin since 1.6.0-RC2 will still be cut as there seem to
be a few critical bugs, e.g. https://issues.apache.org/jira/browse/SPARK-12155
and https://issu
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/8513#issuecomment-162527770
Feel free to do whatever.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8513#issuecomment-162200774
I'm OK with this but I'm only uncertain about merging for 1.6.0. Eh, 1.7.0?
2.0.0? it just matters because of the version label in `@since`. I had
preferred writing `1.7.
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/8513#issuecomment-162099520
@srowen Would you be comfortable merging given the existing review by the
original author? Or should I get another set of eyes to take a look?
---
If your project is se
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8513#issuecomment-161235408
Although the window size doesn't matter a lot, yeah, it seems desirable to
make it configurable.
---
If your project is set up for it, you can reply to this email and ha
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/8513#issuecomment-161093540
ping @mengxr or @jkbradley if this looks ok to you it would be nice to get
merged in
---
If your project is set up for it, you can reply to this email and have your
rep
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/8513#issuecomment-148232521
@Ishiihara do you think it is worth merging in then or not so much? The
documentation I've seen for different word2vec implementations seem to indicate
that changing the
Github user Ishiihara commented on the pull request:
https://github.com/apache/spark/pull/8513#issuecomment-144873979
@holdenk LGTM. The reason to make the window size constant is that the
window size does not affect the result too much given a large corpus.
---
If your project is s
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/8513#issuecomment-144871284
ping @mengxr who has some recent commits in this file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/8513#issuecomment-141564183
cc @Ishiihara who I think was maybe the original author of the fixed window
size.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/8513#discussion_r38454541
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -49,6 +49,17 @@ private[feature] trait Word2VecBase extends Params
def
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8513#issuecomment-136546843
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8513#issuecomment-136546841
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8513#issuecomment-136546775
[Test build #41847 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41847/console)
for PR 8513 at commit
[`c125c3b`](https://github.
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8513#discussion_r38378451
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -49,6 +49,17 @@ private[feature] trait Word2VecBase extends Params
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8513#issuecomment-136540084
[Test build #41847 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41847/consoleFull)
for PR 8513 at commit
[`c125c3b`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8513#issuecomment-136539645
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8513#issuecomment-136539627
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/8513#discussion_r38376603
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -49,6 +49,17 @@ private[feature] trait Word2VecBase extends Params
def
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/8513#issuecomment-136528306
LGTM, minor doc comments which could be addressed in separate PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8513#discussion_r38372402
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -49,6 +49,17 @@ private[feature] trait Word2VecBase extends Params
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8513#discussion_r38372311
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -49,6 +49,17 @@ private[feature] trait Word2VecBase extends Params
39 matches
Mail list logo
