Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r43162207
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala
---
@@ -991,3 +991,73 @@ case class StddevFunction(
}
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-151362354
Had an offline discussion with @yhuai. We can remove `fetch_aggregate` from
whitelist. We already tested all the functions there in SQL queries. We can
create a new JIRA
Github user sethah commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-151267064
I guess this is still failing HiveComparisonTest due to small error in the
variance.
[info] !== HIVE - 1 row(s) ==
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-151248009
**[Test build #44366 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44366/consoleFull)**
for PR 9003 at commit
[`3045e3b`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-151248176
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-151248172
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-151213216
**[Test build #44366 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44366/consoleFull)**
for PR 9003 at commit
[`3045e3b`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-151212601
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-151212635
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sethah commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-151211786
@mengxr Corrected `variance` to yield the population variance. Tests should
pass now.
---
If your project is set up for it, you can reply to this email and have your
rep
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150939324
@sethah It seems that `VARIANCE` in HIVE returns the population variance.
It is the same in MySQL:
https://dev.mysql.com/doc/refman/5.0/en/group-by-functions.html#functio
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150736289
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150736290
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150736271
**[Test build #44272 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44272/consoleFull)**
for PR 9003 at commit
[`b86386a`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150729098
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150729097
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150729081
**[Test build #44267 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44267/consoleFull)**
for PR 9003 at commit
[`cf8a14b`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150721424
**[Test build #44272 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44272/consoleFull)**
for PR 9003 at commit
[`b86386a`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150719854
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150719844
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150713085
**[Test build #44267 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44267/consoleFull)**
for PR 9003 at commit
[`cf8a14b`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150712741
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150712754
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42923579
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -930,3 +930,330 @@ object HyperLogLogPlusPlus
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42923553
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -930,3 +930,330 @@ object HyperLogLogPlusPlus
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42923519
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -930,3 +930,332 @@ object HyperLogLogPlusPlus
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150662563
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150662564
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150662310
**[Test build #44234 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44234/consoleFull)**
for PR 9003 at commit
[`fd3f4d6`](https://git
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150655247
LGTM except minor inline comments. Ping @yhuai for a final pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42897839
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -930,3 +930,330 @@ object HyperLogLogPlusPlus
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42897843
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -930,3 +930,330 @@ object HyperLogLogPlusPlus
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42897835
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -930,3 +930,327 @@ object HyperLogLogPlusPlus
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42897850
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -930,3 +930,330 @@ object HyperLogLogPlusPlus
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150637284
**[Test build #44234 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44234/consoleFull)**
for PR 9003 at commit
[`fd3f4d6`](https://gith
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42889941
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -930,3 +930,327 @@ object HyperLogLogPlusPlus
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42889772
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -930,3 +930,327 @@ object HyperLogLogPlusPlus
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42889712
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -930,3 +930,327 @@ object HyperLogLogPlusPlus
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42889596
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -930,3 +930,327 @@ object HyperLogLogPlusPlus
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42889558
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -930,3 +930,327 @@ object HyperLogLogPlusPlus
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150636269
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150636243
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42879337
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -930,3 +930,327 @@ object HyperLogLogPlusPlus
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150389761
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150389712
**[Test build #44179 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44179/consoleFull)**
for PR 9003 at commit
[`3ef2faa`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150389765
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42820025
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -930,3 +930,327 @@ object HyperLogLogPlusPlus
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42813128
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -930,3 +930,327 @@ object HyperLogLogPlusPlus
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42813053
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -930,3 +930,327 @@ object HyperLogLogPlusPlus
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42813076
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -857,3 +857,329 @@ object HyperLogLogPlusPlus
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42813023
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -930,3 +930,327 @@ object HyperLogLogPlusPlus
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42813001
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -930,3 +930,327 @@ object HyperLogLogPlusPlus
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42812941
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -930,3 +930,327 @@ object HyperLogLogPlusPlus
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42812969
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -930,3 +930,327 @@ object HyperLogLogPlusPlus
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42812933
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -930,3 +930,327 @@ object HyperLogLogPlusPlus
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42812911
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -930,3 +930,327 @@ object HyperLogLogPlusPlus
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42812923
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -930,3 +930,327 @@ object HyperLogLogPlusPlus
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42812895
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -930,3 +930,327 @@ object HyperLogLogPlusPlus
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150368373
**[Test build #44179 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44179/consoleFull)**
for PR 9003 at commit
[`3ef2faa`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150367608
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150367576
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150365606
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150365530
**[Test build #44165 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44165/consoleFull)**
for PR 9003 at commit
[`e0c5c88`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150365603
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150328874
**[Test build #44165 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44165/consoleFull)**
for PR 9003 at commit
[`e0c5c88`](https://gith
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42793409
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -857,3 +857,329 @@ object HyperLogLogPlusPlus
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150327278
Build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150327256
Build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150324367
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150324365
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150324361
**[Test build #44164 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44164/consoleFull)**
for PR 9003 at commit
[`2c9046f`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150323291
**[Test build #44164 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44164/consoleFull)**
for PR 9003 at commit
[`2c9046f`](https://gith
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42790961
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala ---
@@ -168,6 +191,28 @@ object QueryTest {
return None
}
+ /*
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150322612
Build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150322595
Build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42717893
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -221,4 +221,40 @@ class DataFrameAggregateSuite extends QueryTest
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150105959
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150105958
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150105932
**[Test build #44119 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44119/consoleFull)**
for PR 9003 at commit
[`1594aba`](https://git
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42706392
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -221,4 +221,40 @@ class DataFrameAggregateSuite extends QueryTest w
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150086706
**[Test build #44119 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44119/consoleFull)**
for PR 9003 at commit
[`1594aba`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150085187
Build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-150085176
Build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42697800
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -221,4 +221,40 @@ class DataFrameAggregateSuite extends QueryTest
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42677457
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -857,3 +857,329 @@ object HyperLogLogPlusPlus
Github user JihongMA commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-149997989
Seth, no need to implement the old interface, simply put a placeholder for
resolving it is sufficient, which will go away when this code path is removed.
here
Github user JihongMA commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42668167
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -857,3 +857,329 @@ object HyperLogLogPlusPl
Github user JihongMA commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42665351
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -857,3 +857,329 @@ object HyperLogLogPlusPl
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-149790455
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-149790428
**[Test build #44046 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44046/consoleFull)**
for PR 9003 at commit
[`62c515c`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-149790453
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42584878
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -857,3 +857,329 @@ object HyperLogLogPlusPlus
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42584819
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -857,3 +857,329 @@ object HyperLogLogPlusPlus
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-149788655
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-149788654
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user sethah commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-149788583
@mengxr Addressed all comments and rearranged the class inheritances for
case classes. I made another abstract class `SecondMoment` which all `Variance`
classes inherit f
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-149787874
**[Test build #44046 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44046/consoleFull)**
for PR 9003 at commit
[`62c515c`](https://gith
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42584417
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -842,3 +699,302 @@ object HyperLogLogPlusPlus
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42584440
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -842,3 +699,302 @@ object HyperLogLogPlusPlus
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/9003#discussion_r42584447
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -842,3 +699,302 @@ object HyperLogLogPlusPlus
1 - 100 of 154 matches
Mail list logo
