Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8842#issuecomment-142083073
I support this change, which amounts to adding licenses to files that
didn't have it before. Now, if someone cloned `spark-defaults.conf` it would
actually pass RAT check
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8842#issuecomment-141846138
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8842#issuecomment-141846139
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8842#issuecomment-141846118
[Test build #42735 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42735/console)
for PR 8842 at commit
[`959e1cb`](https://github.
Github user rekhajoshm commented on the pull request:
https://github.com/apache/spark/pull/8842#issuecomment-141838427
Thanks @srowen for your comments.
While it is regex, bit different, the other folders you highlight needs
exclusion.For example local-* are test resource file
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8842#issuecomment-141837666
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8842#issuecomment-141837665
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8842#issuecomment-141836094
[Test build #42735 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42735/consoleFull)
for PR 8842 at commit
[`959e1cb`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8842#issuecomment-141836044
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8842#issuecomment-141836042
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8842#issuecomment-141835816
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8842#issuecomment-141835821
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8842#issuecomment-141832701
Yeah I'm mixing up a few things here. You're right none of them do have
header files. I think the template files should have the same header IMHO
unless there's some reas
Github user rekhajoshm commented on the pull request:
https://github.com/apache/spark/pull/8842#issuecomment-141831005
Ok @srowen .If you both review, validate its not correct/needed, thats
fine. @rxin
imo more than how the configuration is done or whether call should ever be
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8842#issuecomment-141826632
Running tests including things like RAT checks is usually for preparing a
packaging of Spark. If you have `spark-defaults.conf` in there then you are
also running a local
Github user rekhajoshm commented on the pull request:
https://github.com/apache/spark/pull/8842#issuecomment-141820464
thanks @rxin and @srowen for your quick review comments. @rxin i need it
for ./dev/run-tests to run correctly. imo nothing under conf/ folder needs to
be checked for
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8842#discussion_r39932853
--- Diff: .rat-excludes ---
@@ -15,15 +15,15 @@ TAGS
RELEASE
control
docs
-docker.properties.template
-fairscheduler.xml.template
-sp
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/8842#issuecomment-141817811
@rekhajoshm why do you need this change? This file is mostly run by Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8842#discussion_r39932759
--- Diff: .rat-excludes ---
@@ -15,15 +15,15 @@ TAGS
RELEASE
control
docs
-docker.properties.template
-fairscheduler.xml.template
-spar
Github user rekhajoshm commented on the pull request:
https://github.com/apache/spark/pull/8842#issuecomment-141760641
retest please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8842#issuecomment-141753849
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8842#issuecomment-141753838
[Test build #42725 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42725/console)
for PR 8842 at commit
[`6285eb3`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8842#issuecomment-141753851
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8842#issuecomment-141747459
[Test build #42725 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42725/consoleFull)
for PR 8842 at commit
[`6285eb3`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8842#issuecomment-141746487
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8842#issuecomment-141746485
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
GitHub user rekhajoshm opened a pull request:
https://github.com/apache/spark/pull/8842
[SPARK-10718] [BUILD] Check License should not verify conf files for license
Check License should not verify conf files for license
You can merge this pull request into a Git repository by runnin
27 matches
Mail list logo
