Github user chutium commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-198071715
anyone tried use --hivevar or --hiveconf with beeline after this change?
variables from JDBC client is no more available in the hive session.
refer to
Github user Neuw84 commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-175916186
@deenar, I saw it after many hours reading the code in the web docs .
Although, I think that the HiveSparkContext should implement the same logic as
the SparkContext
Github user deenar commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-175871622
@Neuw84, i presume you are connecting TOAD to Spark SQL via the thrift
server. You might need to set spark.sql.hive.thriftServer.singleSession=true
to preserve the pre
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-169077537
@Neuw84 Since 1.6, each SQLContext will have separated session, you should
share the same SQLContext in this case (using SQLContext.getOrCreate()).
---
If your project
Github user Neuw84 commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-169046278
Since upgrading to Spark 1.6 I can´t query temp tables created from
SparkStreaming using Apache Toad.
The relevant Spark Streaming part.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r42816917
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1196,46 +1174,90 @@ class SQLContext(@transient val sparkContext:
SparkContext)
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r42816849
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1196,46 +1174,90 @@ class SQLContext(@transient val sparkContext:
SparkContext)
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r42816551
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1196,46 +1174,90 @@ class SQLContext(@transient val sparkContext:
SparkContext)
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r42817021
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1196,46 +1174,90 @@ class SQLContext(@transient val sparkContext:
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r42817261
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1196,46 +1174,90 @@ class SQLContext(@transient val sparkContext:
SparkContext)
Github user WangTaoTheTonic commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146812382
Nice work! As it is a blocker could we merge this into branch-1.5 too?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146898039
@WangTaoTheTonic Since this is a not a bug fix (instead, a major new
feature), we will not merge it to branch-1.5. It will be released with Spark
1.6.0.
---
If your
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41541665
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1196,49 +1174,101 @@ class SQLContext(@transient val sparkContext:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146633053
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146633072
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41542722
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1196,49 +1174,101 @@ class SQLContext(@transient val sparkContext:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146634524
[Test build #43407 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43407/consoleFull)
for PR 8909 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146715402
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146715308
[Test build #43428 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43428/console)
for PR 8909 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146682934
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146682900
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146683288
[Test build #43428 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43428/consoleFull)
for PR 8909 at commit
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146699044
@marmbrus @yhuai @andrewor14 I should have addressed all of your comments
(except lack of more docs), could you take another pass? The failed test is not
related to
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146715405
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146725869
Merged into master, new comments will be addressed in follow-up PR, thanks
you all!
---
If your project is set up for it, you can reply to this email and have your
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8909
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146725227
Non-hive parts LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146668946
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146668949
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146668852
[Test build #43407 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43407/console)
for PR 8909 at commit
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41455821
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -69,13 +84,24 @@ private[hive] class HiveQLDialect extends ParserDialect
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146351112
[Test build #43350 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43350/consoleFull)
for PR 8909 at commit
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41456305
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
---
@@ -210,6 +190,9 @@
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146366859
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146366850
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41447708
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -51,22 +51,42 @@ class SimpleFunctionRegistry
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41449262
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala
---
@@ -159,7 +159,7 @@ class CliSuite extends
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41456023
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -264,12 +262,16 @@ private[hive] object HiveQl extends Logging {
*
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41456081
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -1133,6 +1133,17 @@ class HiveQuerySuite extends
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41455637
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1196,48 +1174,93 @@ class SQLContext(@transient val sparkContext:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146349780
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41455693
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -64,18 +63,28 @@ import org.apache.spark.util.Utils
*
* @since 1.0.0
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41457829
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -264,12 +262,16 @@ private[hive] object HiveQl extends Logging {
*
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146367974
[Test build #43357 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43357/consoleFull)
for PR 8909 at commit
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146354744
@davies Thanks for checking! For UDF, we can use `hive-contrib-0.13.1.jar`
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146367482
[Test build #43356 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43356/consoleFull)
for PR 8909 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146367511
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146367494
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146349700
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146365434
@yhuai UDF and UDTF are also covered by testes, also checked that manually,
work fine.
---
If your project is set up for it, you can reply to this email and have your
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146365916
Cool. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41462336
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1196,49 +1174,101 @@ class SQLContext(@transient val sparkContext:
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41449487
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
---
@@ -289,16 +293,15 @@ class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41462111
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1196,49 +1174,101 @@ class SQLContext(@transient val sparkContext:
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41450098
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -1133,6 +1133,17 @@ class HiveQuerySuite extends
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41450931
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -1133,6 +1133,17 @@ class HiveQuerySuite extends
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41450970
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
---
@@ -148,53 +150,88 @@ private[hive] class
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41450974
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
---
@@ -136,7 +137,8 @@ private[hive] class
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41449894
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
---
@@ -136,7 +137,8 @@ private[hive] class
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146353081
@yhuai `ADD JAR` with SERDE is already covered well by unit tests
(including JDBC client and Cli and HiveContext). `--jar` is tested manually,
work well. Which jar
Github user navis commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146104351
@davies I love the idea removing thread-local, which caused headache for me
doing #7118. One thing I like to see also fixed in here is that jdbc meta calls
like
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41464483
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1196,49 +1174,101 @@ class SQLContext(@transient val sparkContext:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41462407
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1196,49 +1174,101 @@ class SQLContext(@transient val sparkContext:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146399329
[Test build #1856 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1856/console)
for PR 8909 at commit
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41462815
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1196,49 +1174,101 @@ class SQLContext(@transient val sparkContext:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146370209
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146370148
[Test build #43356 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43356/console)
for PR 8909 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146370212
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146372475
[Test build #1856 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1856/consoleFull)
for PR 8909 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146386181
[Test build #43350 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43350/console)
for PR 8909 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146386233
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146386234
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41462692
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1196,49 +1174,101 @@ class SQLContext(@transient val sparkContext:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146370739
[Test build #43357 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43357/console)
for PR 8909 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146370859
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146370861
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41420084
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -51,22 +51,42 @@ class SimpleFunctionRegistry
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41420506
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -64,18 +63,28 @@ import org.apache.spark.util.Utils
*
* @since
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41420832
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1208,36 +1204,72 @@ object SQLContext {
private val INSTANTIATION_LOCK
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41420887
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1208,36 +1204,72 @@ object SQLContext {
private val INSTANTIATION_LOCK
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41420988
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1208,36 +1204,72 @@ object SQLContext {
private val INSTANTIATION_LOCK
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41421063
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1208,36 +1204,72 @@ object SQLContext {
private val INSTANTIATION_LOCK
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41421146
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala ---
@@ -89,6 +80,7 @@ private[sql] class CacheManager(sqlContext:
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41421639
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1208,36 +1204,72 @@ object SQLContext {
private val INSTANTIATION_LOCK
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41421569
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1208,36 +1204,72 @@ object SQLContext {
private val INSTANTIATION_LOCK
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41422069
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala
---
@@ -159,7 +159,7 @@ class CliSuite extends
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41422209
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
---
@@ -289,16 +293,15 @@ class
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41422438
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
---
@@ -148,53 +150,88 @@ private[hive] class
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41429939
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -264,12 +262,16 @@ private[hive] object HiveQl extends Logging {
*
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146294817
This is super nice! It will be great if we can manually test the following
cases to make sure Hive UDFs and SerDes added through user jars are good:
* a spark-shell
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/8909#issuecomment-146281028
@davies, this is great. Much cleaner than the old implementation!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41424458
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -410,7 +436,11 @@ class HiveContext(sc: SparkContext) extends
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41425289
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1208,36 +1204,72 @@ object SQLContext {
private val INSTANTIATION_LOCK =
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41425044
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1208,36 +1204,72 @@ object SQLContext {
private val INSTANTIATION_LOCK =
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41426540
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -69,13 +84,24 @@ private[hive] class HiveQLDialect extends ParserDialect
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41427708
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
---
@@ -148,53 +150,88 @@ private[hive] class
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41423130
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -1133,6 +1133,17 @@ class HiveQuerySuite extends
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41423533
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
@@ -116,27 +116,19 @@ class TestHiveContext(sc: SparkContext) extends
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41424269
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -64,18 +63,28 @@ import org.apache.spark.util.Utils
*
* @since 1.0.0
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8909#discussion_r41424399
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -64,18 +63,28 @@ import org.apache.spark.util.Utils
*
* @since 1.0.0
1 - 100 of 113 matches
Mail list logo
