Github user sethah commented on the pull request:
https://github.com/apache/spark/pull/8883#issuecomment-215559305
ping @yanboliang Is this still on anyone's radar? I think it would be
really useful. I can help review if needed. Maybe start by fixing merge
conflicts? :D
---
If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8883#issuecomment-163703431
[Test build #47504 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47504/console)
for PR 8883 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8883#issuecomment-163703668
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8883#issuecomment-163703666
Build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8883#issuecomment-163646231
[Test build #47504 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47504/consoleFull)
for PR 8883 at commit
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8883#issuecomment-157885506
> Would transform and predict confuse users?
Probably. Not sure what's best. We could also just overload transform,
but that would cause problems for the
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8883#discussion_r45264025
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Predictor.scala ---
@@ -190,7 +190,6 @@ abstract class PredictionModel[FeaturesType, M <:
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8883#issuecomment-157873290
I support making those method public. Just one concern about the names.
Would `transform` and `predict` confuse users? And what does `predict` mean by
default if there
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/8883#issuecomment-148037408
@mengxr @jkbradley Could you review this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
