[GitHub] spark pull request: [SPARK-11275][SQL] Rollup and Cube Generates t...

2015-11-19 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/9419#issuecomment-158237648 Thank you everyone! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-11275][SQL] Rollup and Cube Generates t...

2015-11-19 Thread gatorsmile
Github user gatorsmile closed the pull request at: https://github.com/apache/spark/pull/9419 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11275][SQL] Rollup and Cube Generates t...

2015-11-19 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/9419#issuecomment-158237587 @yhuai Sorry. I did not pay attention to this. I will try the new implementation this weekend. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-11275][SQL] Rollup and Cube Generates t...

2015-11-19 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9419#issuecomment-158230054 @gatorsmile Thank you for working on this. However, I believe #9815 is a better approach to fix this issue and I have merged that. How about we close this PR? --- If you

[GitHub] spark pull request: [SPARK-11275][SQL] Rollup and Cube Generates t...

2015-11-11 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/9419#issuecomment-155973699 Thank you, Hao! Will do it in the next few days. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] spark pull request: [SPARK-11275][SQL] Rollup and Cube Generates t...

2015-11-11 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/9419#issuecomment-155964972 Yes, I think so, and sorry, that I am busy with something else, and will dive in next week for the detailed review. --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-11275][SQL] Rollup and Cube Generates t...

2015-11-11 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/9419#issuecomment-155951403 Please let me know if I need to resolve these conflicts. @cloud-fan @chenghao-intel @marmbrus @rxin --- If your project is set up for it, you can reply to this emai

[GitHub] spark pull request: [SPARK-11275][SQL] Rollup and Cube Generates t...

2015-11-05 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/9419#discussion_r44107333 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -232,7 +232,7 @@ class Analyzer( // substi

[GitHub] spark pull request: [SPARK-11275][SQL] Rollup and Cube Generates t...

2015-11-04 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/9419#discussion_r43968503 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -232,7 +232,7 @@ class Analyzer( // su

[GitHub] spark pull request: [SPARK-11275][SQL] Rollup and Cube Generates t...

2015-11-03 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/9419#discussion_r43850164 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -232,7 +232,7 @@ class Analyzer( // substi

[GitHub] spark pull request: [SPARK-11275][SQL] Rollup and Cube Generates t...

2015-11-03 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/9419#issuecomment-153547807 Yes, true, but in different approach. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] spark pull request: [SPARK-11275][SQL] Rollup and Cube Generates t...

2015-11-03 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9419#issuecomment-153546000 is this PR fix the sample problem with https://github.com/apache/spark/pull/9429? --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] spark pull request: [SPARK-11275][SQL] Rollup and Cube Generates t...

2015-11-03 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/9419#discussion_r43833223 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -232,7 +232,7 @@ class Analyzer( // su

[GitHub] spark pull request: [SPARK-11275][SQL] Rollup and Cube Generates t...

2015-11-03 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/9419#discussion_r43797241 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDataFrameAnalyticsSuite.scala --- @@ -17,7 +17,7 @@ package org.apache.spark.sq

[GitHub] spark pull request: [SPARK-11275][SQL] Rollup and Cube Generates t...

2015-11-03 Thread andrew-svds
Github user andrew-svds commented on a diff in the pull request: https://github.com/apache/spark/pull/9419#discussion_r43790684 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDataFrameAnalyticsSuite.scala --- @@ -17,7 +17,7 @@ package org.apache.spark.s