Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11961
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/11961#issuecomment-202715900
LGTM
Merging with master
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11961#discussion_r57673061
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala
---
@@ -222,19 +222,15 @@ final class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11961#issuecomment-202613948
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11961#issuecomment-202613953
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11961#issuecomment-202613345
**[Test build #54368 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54368/consoleFull)**
for PR 11961 at commit
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/11961#discussion_r57641521
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala
---
@@ -119,6 +119,31 @@ class GBTClassifierSuite extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11961#issuecomment-202596515
**[Test build #54368 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54368/consoleFull)**
for PR 11961 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11961#issuecomment-202595487
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11961#issuecomment-202595483
**[Test build #54366 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54366/consoleFull)**
for PR 11961 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11961#issuecomment-202595489
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11961#issuecomment-202595164
**[Test build #54366 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54366/consoleFull)**
for PR 11961 at commit
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/11961#discussion_r57639931
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala
---
@@ -222,19 +222,15 @@ final class
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/11961#issuecomment-202570826
(one response to an outdated diff above: "I did mean to move the
implementation of feature importances to TreeEnsembleModel, just for
organization.")
Thanks
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11961#discussion_r57628686
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala
---
@@ -274,4 +276,24 @@ private[ml] object GradientBoostedTrees
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11961#discussion_r57628659
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala
---
@@ -222,19 +222,15 @@ final class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11961#issuecomment-202525379
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11961#issuecomment-202525383
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11961#issuecomment-202525173
**[Test build #54334 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54334/consoleFull)**
for PR 11961 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11961#issuecomment-202510375
**[Test build #54334 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54334/consoleFull)**
for PR 11961 at commit
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/11961#discussion_r57606190
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala
---
@@ -274,4 +276,24 @@ private[ml] object GradientBoostedTrees
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/11961#discussion_r57605613
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -240,6 +240,17 @@ final class GBTClassificationModel
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/11961#discussion_r57605639
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala
---
@@ -222,16 +222,10 @@ final class
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11961#discussion_r57540533
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -240,6 +240,17 @@ final class GBTClassificationModel
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11961#discussion_r57540542
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala
---
@@ -274,4 +276,24 @@ private[ml] object GradientBoostedTrees
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11961#discussion_r57540535
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala
---
@@ -222,16 +222,10 @@ final class
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11961#discussion_r57540544
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala
---
@@ -119,6 +119,31 @@ class GBTClassifierSuite extends
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11961#issuecomment-201376017
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11961#issuecomment-201376022
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11961#issuecomment-201375885
**[Test build #54186 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54186/consoleFull)**
for PR 11961 at commit
Github user sethah commented on the pull request:
https://github.com/apache/spark/pull/11961#issuecomment-201361949
cc @jkbradley whenever you get a chance, could you take a look? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/11961#discussion_r57462916
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala
---
@@ -119,6 +119,31 @@ class GBTClassifierSuite extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/11961#discussion_r57462635
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala
---
@@ -222,16 +222,10 @@ final class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11961#issuecomment-201358136
**[Test build #54186 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54186/consoleFull)**
for PR 11961 at commit
GitHub user sethah opened a pull request:
https://github.com/apache/spark/pull/11961
[SPARK-11730][ML] Add feature importances for GBTs.
## What changes were proposed in this pull request?
Now that GBTs have been moved to ML, they can use the implementation of
feature
35 matches
Mail list logo
