[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-29 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167859672 Thanks for putting the effort into this @tedyu. It did move us forward in the sense that now we know we can't use Kryo for serializing task results. I'm going to clo

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-29 Thread tedyu
Github user tedyu closed the pull request at: https://github.com/apache/spark/pull/10368 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-29 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167855990 What first two days of work are you referring to? The problem is we just can't use Kryo for serializing task results because there might be unregistered classes. Bec

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-29 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167802141 I think the first two days' work aligns with SPARK-12414. Is it possible to keep that (without modification to KryoSerializer and the new test) ? --- If your pr

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-28 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/10368#discussion_r48513944 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskResultGetterSuite.scala --- @@ -81,6 +81,16 @@ class TaskResultGetterSuite extends SparkFunSuite w

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-28 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167673871 As @zsxwing pointed out, the existing unit tests are not sufficient because they didn't catch the fact that `ShuffleReadMetrics` et al must also be registered. This

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-28 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10368#discussion_r48511217 --- Diff: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala --- @@ -109,6 +111,9 @@ class KryoSerializer(conf: SparkConf) kryo

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-28 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10368#discussion_r48508806 --- Diff: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala --- @@ -109,6 +111,9 @@ class KryoSerializer(conf: SparkConf) kryo.re

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-28 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/10368#discussion_r48507734 --- Diff: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala --- @@ -109,6 +111,9 @@ class KryoSerializer(conf: SparkConf) kryo.regi

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-28 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10368#discussion_r48507496 --- Diff: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala --- @@ -109,6 +111,9 @@ class KryoSerializer(conf: SparkConf) kryo.re

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-27 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10368#discussion_r48458317 --- Diff: core/src/test/scala/org/apache/spark/HeartbeatReceiverSuite.scala --- @@ -220,7 +222,7 @@ class HeartbeatReceiverSuite } else {

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167101252 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167101251 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167101101 **[Test build #48304 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48304/consoleFull)** for PR 10368 at commit [`a4173eb`](https://g

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-24 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167086261 ``` sbt.ForkMain$ForkError: org.scalatest.exceptions.TestFailedDueToTimeoutException: The code passed to eventually never returned normally. Attempted 209 times over

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167081572 **[Test build #48304 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48304/consoleFull)** for PR 10368 at commit [`a4173eb`](https://gi

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-24 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167079477 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167061071 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167061036 **[Test build #48288 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48288/consoleFull)** for PR 10368 at commit [`a4173eb`](https://g

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167061069 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167047677 **[Test build #48288 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48288/consoleFull)** for PR 10368 at commit [`a4173eb`](https://gi

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167046527 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167046506 ``` [info] PostgresIntegrationSuite: [info] Exception encountered when attempting to run a suite with class name: org.apache.spark.sql.jdbc.PostgresIntegrationSuit

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167044665 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167044664 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167044643 **[Test build #48283 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48283/consoleFull)** for PR 10368 at commit [`a4173eb`](https://g

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167039836 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167039814 **[Test build #48279 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48279/consoleFull)** for PR 10368 at commit [`5011926`](https://g

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167039837 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167038607 **[Test build #48283 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48283/consoleFull)** for PR 10368 at commit [`a4173eb`](https://gi

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167033459 **[Test build #48279 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48279/consoleFull)** for PR 10368 at commit [`5011926`](https://gi

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167030489 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167030488 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167030479 **[Test build #48278 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48278/consoleFull)** for PR 10368 at commit [`ac0199a`](https://g

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167028329 **[Test build #48278 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48278/consoleFull)** for PR 10368 at commit [`ac0199a`](https://gi

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167025356 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167025357 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167025330 **[Test build #48275 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48275/consoleFull)** for PR 10368 at commit [`846b939`](https://g

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167024446 **[Test build #48275 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48275/consoleFull)** for PR 10368 at commit [`846b939`](https://gi

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167022107 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167022108 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167022099 **[Test build #48273 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48273/consoleFull)** for PR 10368 at commit [`710dc44`](https://g

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167019833 **[Test build #48273 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48273/consoleFull)** for PR 10368 at commit [`710dc44`](https://gi

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167018650 Here was why I implemented equals for Map (from #48257): {code} [info] - Bug: SPARK-12415 *** FAILED *** (3 milliseconds) [info] java.nio.HeapByteBuffer[pos=0

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167016785 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167016754 **[Test build #48257 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48257/consoleFull)** for PR 10368 at commit [`7cfde71`](https://g

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167016784 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10368#discussion_r48389780 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskResult.scala --- @@ -46,6 +46,8 @@ class DirectTaskResult[T](var valueBytes: ByteBuffer, var

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167015301 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167015302 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167015292 **[Test build #48269 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48269/consoleFull)** for PR 10368 at commit [`4b5657b`](https://g

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/10368#discussion_r48389541 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskResult.scala --- @@ -46,6 +46,8 @@ class DirectTaskResult[T](var valueBytes: ByteBuffer, var accu

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167014373 **[Test build #48269 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48269/consoleFull)** for PR 10368 at commit [`4b5657b`](https://gi

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167014071 LGTM except some nits. Thanks a lot for fixing this @tedyu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10368#discussion_r48389325 --- Diff: core/src/test/scala/org/apache/spark/HeartbeatReceiverSuite.scala --- @@ -220,7 +222,7 @@ class HeartbeatReceiverSuite } else {

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10368#discussion_r48389313 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskResult.scala --- @@ -46,6 +46,8 @@ class DirectTaskResult[T](var valueBytes: ByteBuffer, var ac

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10368#discussion_r48389119 --- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala --- @@ -215,6 +215,18 @@ class TaskMetrics extends Serializable { input

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10368#discussion_r48385365 --- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala --- @@ -215,6 +215,18 @@ class TaskMetrics extends Serializable { inputMet

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10368#discussion_r48384718 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskResult.scala --- @@ -46,6 +46,23 @@ class DirectTaskResult[T](var valueBytes: ByteBuffer, var a

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166999771 **[Test build #48257 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48257/consoleFull)** for PR 10368 at commit [`7cfde71`](https://gi

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10368#discussion_r48372722 --- Diff: core/src/test/scala/org/apache/spark/serializer/KryoSerializerSuite.scala --- @@ -154,6 +155,19 @@ class KryoSerializerSuite extends SparkFunSuite

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10368#discussion_r48372644 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskResult.scala --- @@ -46,6 +46,26 @@ class DirectTaskResult[T](var valueBytes: ByteBuffer, var a

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10368#discussion_r48372093 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskResult.scala --- @@ -46,6 +46,26 @@ class DirectTaskResult[T](var valueBytes: ByteBuffer, var a

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166972579 The rest of it looks OK. @zsxwing can you take another pass? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10368#discussion_r48371257 --- Diff: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala --- @@ -109,6 +111,9 @@ class KryoSerializer(conf: SparkConf) kryo

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10368#discussion_r48371027 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskResult.scala --- @@ -46,6 +46,26 @@ class DirectTaskResult[T](var valueBytes: ByteBuffer, va

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10368#discussion_r48370672 --- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala --- @@ -215,6 +215,19 @@ class TaskMetrics extends Serializable { input

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-21 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166387628 @andrewor14 @zsxwing Please take another look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166387458 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166387455 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166387289 **[Test build #48119 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48119/consoleFull)** for PR 10368 at commit [`bc7699c`](https://g

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166358959 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166358956 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166358855 **[Test build #48119 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48119/consoleFull)** for PR 10368 at commit [`bc7699c`](https://gi

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166154566 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166154468 **[Test build #48087 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48087/consoleFull)** for PR 10368 at commit [`86dbca8`](https://g

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166154567 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166149468 **[Test build #48087 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48087/consoleFull)** for PR 10368 at commit [`86dbca8`](https://gi

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166070595 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166070591 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166070476 **[Test build #48070 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48070/consoleFull)** for PR 10368 at commit [`c9ad494`](https://g

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166068982 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166068983 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166068971 **[Test build #48068 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48068/consoleFull)** for PR 10368 at commit [`facf246`](https://g

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166067939 **[Test build #48070 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48070/consoleFull)** for PR 10368 at commit [`c9ad494`](https://gi

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166061058 **[Test build #48068 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48068/consoleFull)** for PR 10368 at commit [`facf246`](https://gi

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-19 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166060830 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-19 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166060825 HeartbeatReceiverSuite.'expire dead hosts' failed Doesn't seem to be related to the PR. --- If your project is set up for it, you can reply to this email and hav

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166059917 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166059915 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166059903 **[Test build #48067 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48067/consoleFull)** for PR 10368 at commit [`facf246`](https://g

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166055164 **[Test build #48067 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48067/consoleFull)** for PR 10368 at commit [`facf246`](https://gi

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-19 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166052576 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166046525 **[Test build #2239 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2239/consoleFull)** for PR 10368 at commit [`facf246`](https://

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166046523 **[Test build #2239 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2239/consoleFull)** for PR 10368 at commit [`facf246`](https://g

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166035113 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166035114 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166035102 **[Test build #48059 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48059/consoleFull)** for PR 10368 at commit [`b65aeb6`](https://g

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166034111 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-166034107 **[Test build #48063 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48063/consoleFull)** for PR 10368 at commit [`facf246`](https://gi

  1   2   >